Sets encoding to null to preserve raw buffers

This commit is contained in:
Florent Vilmart
2016-03-07 23:18:45 -05:00
parent 8300dd8a47
commit f40efe3923
2 changed files with 16 additions and 3 deletions

View File

@@ -217,6 +217,17 @@ describe("httpRequest", () => {
done();
}
});
});
it('should get a cat image', (done) => {
httpRequest({
url: 'http://thecatapi.com/api/images/get?format=src&type=jpg',
followRedirects: true
}).then((res) => {
expect(res.buffer).not.toBe(null);
expect(res.text).not.toBe(null);
done();
})
})
it("should params object to query string", (done) => {

View File

@@ -52,6 +52,8 @@ module.exports = function(options) {
} else if (typeof options.params === 'string') {
options.qs = querystring.parse(options.params);
}
// force the response as a buffer
options.encoding = null;
request(options, (error, response, body) => {
if (error) {
@@ -63,11 +65,11 @@ module.exports = function(options) {
var httpResponse = {};
httpResponse.status = response.statusCode;
httpResponse.headers = response.headers;
httpResponse.buffer = new Buffer(response.body);
httpResponse.buffer = response.body;
httpResponse.cookies = response.headers["set-cookie"];
httpResponse.text = response.body;
httpResponse.text = response.body.toString('utf-8');
try {
httpResponse.data = JSON.parse(response.body);
httpResponse.data = JSON.parse(httpResponse.text);
} catch (e) {}
// Consider <200 && >= 400 as errors
if (httpResponse.status < 200 || httpResponse.status >= 400) {