joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes unhandled promise rejection error while sending push (#4172)

Browse Source
This commit is contained in:
Florent Vilmart
2017-09-17 09:57:07 -04:00
committed by GitHub
parent 8d8a8b250e
commit ba0a51ddc9
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Routers/PushRouter.js
View File

@@ -19,7 +19,9 @@ export class PushRouter extends PromiseRouter {
const promise = new Promise((_resolve) => { const promise = new Promise((_resolve) => {
resolve = _resolve; resolve = _resolve;
}); });
pushController.sendPush(req.body, where, req.config, req.auth, (pushStatusId) => { let pushStatusId;
pushController.sendPush(req.body, where, req.config, req.auth, (objectId) => {
pushStatusId = objectId;
resolve({ resolve({
headers: { headers: {
'X-Parse-Push-Status-Id': pushStatusId 'X-Parse-Push-Status-Id': pushStatusId
@@ -28,7 +30,9 @@ export class PushRouter extends PromiseRouter {
result: true result: true
} }
}); });
}).catch(req.config.loggerController.error); }).catch((err) => {
req.config.loggerController.error(`_PushStatus ${pushStatusId}: error while sending push`, err);
});
return promise; return promise;
} }

1
src/StatusHandler.js
View File

@@ -247,7 +247,6 @@ export function pushStatusHandler(config, objectId = newObjectId(config.objectId
status: 'failed', status: 'failed',
updatedAt: new Date() updatedAt: new Date()
} }
logger.warn(`_PushStatus ${objectId}: error while sending push`, err);
return handler.update({ objectId }, update); return handler.update({ objectId }, update);
} }