From ba0a51ddc902dc5ce122bf1a1c8f18bce50df92b Mon Sep 17 00:00:00 2001 From: Florent Vilmart Date: Sun, 17 Sep 2017 09:57:07 -0400 Subject: [PATCH] Fixes unhandled promise rejection error while sending push (#4172) --- src/Routers/PushRouter.js | 8 ++++++-- src/StatusHandler.js | 1 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Routers/PushRouter.js b/src/Routers/PushRouter.js index 03889c1c..5f5cf656 100644 --- a/src/Routers/PushRouter.js +++ b/src/Routers/PushRouter.js @@ -19,7 +19,9 @@ export class PushRouter extends PromiseRouter { const promise = new Promise((_resolve) => { resolve = _resolve; }); - pushController.sendPush(req.body, where, req.config, req.auth, (pushStatusId) => { + let pushStatusId; + pushController.sendPush(req.body, where, req.config, req.auth, (objectId) => { + pushStatusId = objectId; resolve({ headers: { 'X-Parse-Push-Status-Id': pushStatusId @@ -28,7 +30,9 @@ export class PushRouter extends PromiseRouter { result: true } }); - }).catch(req.config.loggerController.error); + }).catch((err) => { + req.config.loggerController.error(`_PushStatus ${pushStatusId}: error while sending push`, err); + }); return promise; } diff --git a/src/StatusHandler.js b/src/StatusHandler.js index 818d76fd..eb4cbbfb 100644 --- a/src/StatusHandler.js +++ b/src/StatusHandler.js @@ -247,7 +247,6 @@ export function pushStatusHandler(config, objectId = newObjectId(config.objectId status: 'failed', updatedAt: new Date() } - logger.warn(`_PushStatus ${objectId}: error while sending push`, err); return handler.update({ objectId }, update); }