joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Improve incorrect deprecation log message for auth adapter (#8347)

Browse Source
This commit is contained in:
Manuel
2022-12-06 23:04:37 +01:00
committed by GitHub
parent 536bb2f1ae
commit b48c27049a
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spec/AuthenticationAdapters.spec.js
View File

@@ -590,7 +590,7 @@ describe('AuthenticationProviders', function () {
); );
}); });
it('can depreciate', async () => { it('can deprecate', async () => {
await reconfigureServer(); await reconfigureServer();
const Deprecator = require('../lib/Deprecator/Deprecator'); const Deprecator = require('../lib/Deprecator/Deprecator');
const spy = spyOn(Deprecator, 'logRuntimeDeprecation').and.callFake(() => {}); const spy = spyOn(Deprecator, 'logRuntimeDeprecation').and.callFake(() => {});
@@ -598,8 +598,9 @@ describe('AuthenticationProviders', function () {
Parse.User._registerAuthenticationProvider(provider); Parse.User._registerAuthenticationProvider(provider);
await Parse.User._logInWith('myoauth'); await Parse.User._logInWith('myoauth');
expect(spy).toHaveBeenCalledWith({ expect(spy).toHaveBeenCalledWith({
usage: 'auth.myoauth', usage: 'Using the authentication adapter "myoauth" without explicitly enabling it',
solution: 'auth.myoauth.enabled: true', solution:
'Enable the authentication adapter by setting the Parse Server option "auth.myoauth.enabled: true".',
}); });
}); });
}); });

4
src/Auth.js
View File

@@ -435,8 +435,8 @@ const handleAuthDataValidation = async (authData, req, foundUser) => {
const authProvider = (req.config.auth || {})[provider] || {}; const authProvider = (req.config.auth || {})[provider] || {};
if (authProvider.enabled == null) { if (authProvider.enabled == null) {
Deprecator.logRuntimeDeprecation({ Deprecator.logRuntimeDeprecation({
usage: `auth.${provider}`, usage: `Using the authentication adapter "${provider}" without explicitly enabling it`,
solution: `auth.${provider}.enabled: true`, solution: `Enable the authentication adapter by setting the Parse Server option "auth.${provider}.enabled: true".`,
}); });
} }
if (!validator || authProvider.enabled === false) { if (!validator || authProvider.enabled === false) {