From b48c27049a46edc795a6dfaba9f48f396fb9db29 Mon Sep 17 00:00:00 2001 From: Manuel <5673677+mtrezza@users.noreply.github.com> Date: Tue, 6 Dec 2022 23:04:37 +0100 Subject: [PATCH] refactor: Improve incorrect deprecation log message for auth adapter (#8347) --- spec/AuthenticationAdapters.spec.js | 7 ++++--- src/Auth.js | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/spec/AuthenticationAdapters.spec.js b/spec/AuthenticationAdapters.spec.js index 6fb6ce57..a940880c 100644 --- a/spec/AuthenticationAdapters.spec.js +++ b/spec/AuthenticationAdapters.spec.js @@ -590,7 +590,7 @@ describe('AuthenticationProviders', function () { ); }); - it('can depreciate', async () => { + it('can deprecate', async () => { await reconfigureServer(); const Deprecator = require('../lib/Deprecator/Deprecator'); const spy = spyOn(Deprecator, 'logRuntimeDeprecation').and.callFake(() => {}); @@ -598,8 +598,9 @@ describe('AuthenticationProviders', function () { Parse.User._registerAuthenticationProvider(provider); await Parse.User._logInWith('myoauth'); expect(spy).toHaveBeenCalledWith({ - usage: 'auth.myoauth', - solution: 'auth.myoauth.enabled: true', + usage: 'Using the authentication adapter "myoauth" without explicitly enabling it', + solution: + 'Enable the authentication adapter by setting the Parse Server option "auth.myoauth.enabled: true".', }); }); }); diff --git a/src/Auth.js b/src/Auth.js index 918a64ec..d9a55593 100644 --- a/src/Auth.js +++ b/src/Auth.js @@ -435,8 +435,8 @@ const handleAuthDataValidation = async (authData, req, foundUser) => { const authProvider = (req.config.auth || {})[provider] || {}; if (authProvider.enabled == null) { Deprecator.logRuntimeDeprecation({ - usage: `auth.${provider}`, - solution: `auth.${provider}.enabled: true`, + usage: `Using the authentication adapter "${provider}" without explicitly enabling it`, + solution: `Enable the authentication adapter by setting the Parse Server option "auth.${provider}.enabled: true".`, }); } if (!validator || authProvider.enabled === false) {