joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix unexpected 'delete' trigger issue on LiveQuery (#5031)

Browse Source 
* fix unexpected 'delete' trigger on LiveQuery when response is an error in cloud function beforeDelete

* tested

* Rebuild CI

* Retest due to local machine testing is passed

* Travis testing failed randomly on Cloud Code Logger. I will retry

* retry

* retry
This commit is contained in:
Deokhyun Ko
2018-09-06 05:15:36 -06:00
committed by Florent Vilmart
parent a42101531a
commit 462f5eb54b
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/rest.js
View File

@@ -129,11 +129,6 @@ function del(config, auth, className, objectId) {
var cacheAdapter = config.cacheController; var cacheAdapter = config.cacheController;
cacheAdapter.user.del(firstResult.sessionToken); cacheAdapter.user.del(firstResult.sessionToken);
inflatedObject = Parse.Object.fromJSON(firstResult); inflatedObject = Parse.Object.fromJSON(firstResult);
// Notify LiveQuery server if possible
config.liveQueryController.onAfterDelete(
inflatedObject.className,
inflatedObject
);
return triggers.maybeRunTrigger( return triggers.maybeRunTrigger(
triggers.Types.beforeDelete, triggers.Types.beforeDelete,
auth, auth,
@@ -176,6 +171,8 @@ function del(config, auth, className, objectId) {
); );
}) })
.then(() => { .then(() => {
// Notify LiveQuery server if possible
config.liveQueryController.onAfterDelete(className, inflatedObject);
return triggers.maybeRunTrigger( return triggers.maybeRunTrigger(
triggers.Types.afterDelete, triggers.Types.afterDelete,
auth, auth,