From 462f5eb54b2697ad0abc2d4cd29e194ee3a2ea22 Mon Sep 17 00:00:00 2001 From: Deokhyun Ko Date: Thu, 6 Sep 2018 05:15:36 -0600 Subject: [PATCH] fix unexpected 'delete' trigger issue on LiveQuery (#5031) * fix unexpected 'delete' trigger on LiveQuery when response is an error in cloud function beforeDelete * tested * Rebuild CI * Retest due to local machine testing is passed * Travis testing failed randomly on Cloud Code Logger. I will retry * retry * retry --- src/rest.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/rest.js b/src/rest.js index e36973f8..ff1533b2 100644 --- a/src/rest.js +++ b/src/rest.js @@ -129,11 +129,6 @@ function del(config, auth, className, objectId) { var cacheAdapter = config.cacheController; cacheAdapter.user.del(firstResult.sessionToken); inflatedObject = Parse.Object.fromJSON(firstResult); - // Notify LiveQuery server if possible - config.liveQueryController.onAfterDelete( - inflatedObject.className, - inflatedObject - ); return triggers.maybeRunTrigger( triggers.Types.beforeDelete, auth, @@ -176,6 +171,8 @@ function del(config, auth, className, objectId) { ); }) .then(() => { + // Notify LiveQuery server if possible + config.liveQueryController.onAfterDelete(className, inflatedObject); return triggers.maybeRunTrigger( triggers.Types.afterDelete, auth,