From e074a922fb765e786f06bcc7bb3302d835ddc2e9 Mon Sep 17 00:00:00 2001 From: Drew Gross Date: Thu, 3 Mar 2016 09:44:43 -0800 Subject: [PATCH 1/2] Fix leak warnings in tests, use mongodb-runner from node_modules --- package.json | 2 +- src/index.js | 21 ++++++++++++--------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 29e873da..1b6199cf 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ "build": "./node_modules/.bin/babel src/ -d lib/", "pretest": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} ./node_modules/.bin/mongodb-runner start", "test": "cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node $COVERAGE_OPTION ./node_modules/jasmine/bin/jasmine.js", - "posttest": "mongodb-runner stop", + "posttest": "./node_modules/.bin/mongodb-runner stop", "coverage": "cross-env COVERAGE_OPTION='./node_modules/babel-istanbul/lib/cli.js cover -x **/spec/**' npm test", "start": "node ./bin/parse-server", "prepublish": "npm run build" diff --git a/src/index.js b/src/index.js index 076035f8..49769b12 100644 --- a/src/index.js +++ b/src/index.js @@ -232,15 +232,18 @@ function ParseServer({ api.use(middlewares.handleParseErrors); - process.on('uncaughtException', (err) => { - if( err.code === "EADDRINUSE" ) { // user-friendly message for this common error - console.log(`Unable to listen on port ${err.port}. The port is already in use.`); - process.exit(0); - } - else { - throw err; - } - }); + //This causes tests to spew some useless warnings, so disable in test + if (!process.env.TESTING) { + process.on('uncaughtException', (err) => { + if( err.code === "EADDRINUSE" ) { // user-friendly message for this common error + console.log(`Unable to listen on port ${err.port}. The port is already in use.`); + process.exit(0); + } + else { + throw err; + } + }); + } hooksController.load(); return api; From 7cc059973b30df8c449b51a7bfbe348469aa751b Mon Sep 17 00:00:00 2001 From: Aneesh Devasthale Date: Sat, 5 Mar 2016 10:47:27 +0530 Subject: [PATCH 2/2] Modified the npm dev script to support Windows Windows does not support shebangs/hashbangs. Added the node command to run the bin/dev script. Extension of #831 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1b6199cf..ee0e0b4e 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "nodemon": "^1.8.1" }, "scripts": { - "dev": "npm run build && bin/dev", + "dev": "npm run build && node bin/dev", "build": "./node_modules/.bin/babel src/ -d lib/", "pretest": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} ./node_modules/.bin/mongodb-runner start", "test": "cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node $COVERAGE_OPTION ./node_modules/jasmine/bin/jasmine.js",