ES6-ify

spec/CLI.spec.js

@@ -1,4 +1,4 @@
-var commander = require("../src/cli/utils/commander");
+var commander = require("../src/cli/utils/commander").default;
 
 var definitions = {
   "arg0": "PROGRAM_ARG_0",
@@ -9,10 +9,17 @@ var definitions = {
   "arg2": {
     env: "PROGRAM_ARG_2",
     action: function(value) {
-      return parseInt(value);
+      var value = parseInt(value);
+      if (!Number.isInteger(value)) {
+        throw "port is invalid";
+      }
+      return value;
     }
   },
-  "arg3": {}
+  "arg3": {},
+  "arg4": {
+    default: "arg4Value"
+  }
 }
 
 describe("commander additions", () => {
@@ -23,6 +30,7 @@ describe("commander additions", () => {
     delete commander.arg1;
     delete commander.arg2;
     delete commander.arg3;
+    delete commander.arg4;
     done();
   })
   
@@ -33,6 +41,7 @@ describe("commander additions", () => {
     expect(commander.arg1).toEqual("arg1Value");
     expect(commander.arg2).toEqual(2);
     expect(commander.arg3).toEqual("some");
+    expect(commander.arg4).toEqual("arg4Value");
     done();
   });
   
@@ -46,12 +55,13 @@ describe("commander additions", () => {
     expect(commander.arg0).toEqual("arg0ENVValue");
     expect(commander.arg1).toEqual("arg1ENVValue");
     expect(commander.arg2).toEqual(3);
+    expect(commander.arg4).toEqual("arg4Value");
     done();
   });
   
   it("should load properly use args over env", (done) => {
     commander.loadDefinitions(definitions);
-    commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value"], {
+    commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value", "--arg4", "anotherArg4"], {
       "PROGRAM_ARG_0": "arg0ENVValue",
       "PROGRAM_ARG_1": "arg1ENVValue",
       "PROGRAM_ARG_2": "4",
@@ -59,7 +69,19 @@ describe("commander additions", () => {
     expect(commander.arg0).toEqual("arg0Value");
     expect(commander.arg1).toEqual("arg1ENVValue");
     expect(commander.arg2).toEqual(4);
+    expect(commander.arg4).toEqual("anotherArg4");
     done();
   });
   
-})
+  it("should fail in action as port is invalid", (done) => {
+    commander.loadDefinitions(definitions);
+    expect(()=> {
+      commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value"], {
+        "PROGRAM_ARG_0": "arg0ENVValue",
+        "PROGRAM_ARG_1": "arg1ENVValue",
+        "PROGRAM_ARG_2": "hello",
+      });
+    }).toThrow("port is invalid");
+    done();
+  });
+});