From f310e6678eb729e76e0f56ad3a8c2c813bfa7d4b Mon Sep 17 00:00:00 2001
From: Florent Vilmart <flovilmart@users.noreply.github.com>
Date: Tue, 19 Jul 2016 00:43:34 -0400
Subject: [PATCH] Fix flaky tests (#2324)

* Fix flaky test (There were open connections to the server left after the test finished)

* fix test that's happening on the end of the minute

* remove focus testing
---
 spec/RestCreate.spec.js |  3 ++-
 spec/RestQuery.spec.js  | 33 +++++++++++++++++----------------
 2 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/spec/RestCreate.spec.js b/spec/RestCreate.spec.js
index 9af188c6..155dd11b 100644
--- a/spec/RestCreate.spec.js
+++ b/spec/RestCreate.spec.js
@@ -337,7 +337,8 @@ describe('rest create', () => {
         expect(actual.getFullYear()).toEqual(expected.getFullYear());
         expect(actual.getMonth()).toEqual(expected.getMonth());
         expect(actual.getDate()).toEqual(expected.getDate());
-        expect(actual.getMinutes()).toEqual(expected.getMinutes());
+        // less than a minute, if test happen at the wrong time :/
+        expect(actual.getMinutes() - expected.getMinutes() <= 1).toBe(true);
 
         done();
       });
diff --git a/spec/RestQuery.spec.js b/spec/RestQuery.spec.js
index e5cc9118..78d18d9a 100644
--- a/spec/RestQuery.spec.js
+++ b/spec/RestQuery.spec.js
@@ -7,6 +7,7 @@ var rest = require('../src/rest');
 
 var querystring = require('querystring');
 var request = require('request');
+var rp = require('request-promise');
 
 var config = new Config('test');
 let database = config.database;
@@ -167,37 +168,37 @@ describe('rest query', () => {
         'X-Parse-Application-Id': 'test',
         'X-Parse-REST-API-Key': 'rest'
       };
-      request.get({
+      
+      let p0 = rp.get({
         headers: headers,
         url: 'http://localhost:8378/1/classes/TestParameterEncode?'
                          + querystring.stringify({
                              where: '{"foo":{"$ne": "baz"}}',
                              limit: 1
                          }).replace('=', '%3D'),
-      }, (error, response, body) => {
-        expect(error).toBe(null);
-        var b = JSON.parse(body);
+      }).then(fail, (response) => {
+        let error = response.error;
+        var b = JSON.parse(error);
         expect(b.code).toEqual(Parse.Error.INVALID_QUERY);
-        done();
       });
-    }).then(() => {
-      var headers = {
-        'X-Parse-Application-Id': 'test',
-        'X-Parse-REST-API-Key': 'rest'
-      };
-      request.get({
+
+      let p1 = rp.get({
         headers: headers,
         url: 'http://localhost:8378/1/classes/TestParameterEncode?'
                          + querystring.stringify({
                              limit: 1
                          }).replace('=', '%3D'),
-      }, (error, response, body) => {
-        expect(error).toBe(null);
-        var b = JSON.parse(body);
+      }).then(fail, (response) => {
+        let error = response.error;
+        var b = JSON.parse(error);
         expect(b.code).toEqual(Parse.Error.INVALID_QUERY);
-        done();
       });
-    });
+      return Promise.all([p0, p1]);
+    }).then(done).catch((err) => {
+      console.error(err);
+      fail('should not fail');
+      done();
+    })
   });
 
   it('query with limit = 0', (done) => {