joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure legacy users with authData are not locked out (#4898)

Browse Source 
* Adds fix for issue, ensuring legacy users with no ACL are properly handled

* Runs tests only on mongo
This commit is contained in:
Florent Vilmart
2018-07-18 14:42:50 +00:00
committed by GitHub
parent b22947d4ec
commit efb6c63a95
3 changed files with 47 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/RestWrite.js
View File

@@ -278,13 +278,23 @@ RestWrite.prototype.findUsersWithAuthData = function(authData) {
return findPromise;
}
RestWrite.prototype.filteredObjectsByACL = function(objects) {
if (this.auth.isMaster) {
return objects;
}
return objects.filter((object) => {
if (!object.ACL) {
return true; // legacy users that have no ACL field on them
}
// Regular users that have been locked out.
return object.ACL && Object.keys(object.ACL).length > 0;
});
}
RestWrite.prototype.handleAuthData = function(authData) {
let results;
return this.findUsersWithAuthData(authData).then((r) => {
results = r.filter((user) => {
return !this.auth.isMaster && user.ACL && Object.keys(user.ACL).length > 0;
});
results = this.filteredObjectsByACL(r);
if (results.length > 1) {
// More than 1 user with the passed id's
throw new Parse.Error(Parse.Error.ACCOUNT_ALREADY_LINKED,