joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Username is undefined in email verification link on email change (#8887)

Browse Source
This commit is contained in:
Manuel
2024-01-15 00:47:03 +01:00
committed by GitHub
parent 3c07fcada6
commit e315c137bf
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spec/ValidationAndPasswordsReset.spec.js
View File

@@ -137,6 +137,7 @@ describe('Custom Pages, Email Verification, Password Reset', () => {
spyOn(emailAdapter, 'sendVerificationEmail').and.callFake(options => { spyOn(emailAdapter, 'sendVerificationEmail').and.callFake(options => {
expect(options.link).not.toBeNull(); expect(options.link).not.toBeNull();
expect(options.link).not.toMatch(/token=undefined/); expect(options.link).not.toMatch(/token=undefined/);
expect(options.link).not.toMatch(/username=undefined/);
Promise.resolve(); Promise.resolve();
}); });
const user = new Parse.User(); const user = new Parse.User();

5
src/Controllers/UserController.js
View File

@@ -161,7 +161,8 @@ export class UserController extends AdaptableController {
return; return;
} }
const token = encodeURIComponent(user._email_verify_token); const token = encodeURIComponent(user._email_verify_token);
// We may need to fetch the user in case of update email // We may need to fetch the user in case of update email; only use the `fetchedUser`
// from this point onwards; do not use the `user` as it may not contain all fields.
const fetchedUser = await this.getUserIfNeeded(user); const fetchedUser = await this.getUserIfNeeded(user);
let shouldSendEmail = this.config.sendUserEmailVerification; let shouldSendEmail = this.config.sendUserEmailVerification;
if (typeof shouldSendEmail === 'function') { if (typeof shouldSendEmail === 'function') {
@@ -176,7 +177,7 @@ export class UserController extends AdaptableController {
if (!shouldSendEmail) { if (!shouldSendEmail) {
return; return;
} }
const username = encodeURIComponent(user.username); const username = encodeURIComponent(fetchedUser.username);
const link = buildEmailLink(this.config.verifyEmailURL, username, token, this.config); const link = buildEmailLink(this.config.verifyEmailURL, username, token, this.config);
const options = { const options = {