joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1081 from ParsePlatform/flovilmart.deleteAuthData

Browse Source 
Ensures _auth_data_[provider] gets deleted from document
This commit is contained in:
Florent Vilmart
2016-03-17 19:50:41 -04:00
parent 7194fb195c 5ff186f212
commit e2bcc87810
2 changed files with 47 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
spec/OAuth.spec.js
View File

@@ -1,5 +1,6 @@
var OAuth = require("../src/authDataManager/OAuth1Client"); var OAuth = require("../src/authDataManager/OAuth1Client");
var request = require('request'); var request = require('request');
var Config = require("../src/Config");
describe('OAuth', function() { describe('OAuth', function() {
@@ -266,28 +267,38 @@ describe('OAuth', function() {
model._unlinkFrom("myoauth", { model._unlinkFrom("myoauth", {
success: function(model) { success: function(model) {
ok(!model._isLinked("myoauth"), ok(!model._isLinked("myoauth"),
"User should not be linked to myoauth"); "User should not be linked to myoauth");
ok(!provider.synchronizedUserId, "User id should be cleared"); ok(!provider.synchronizedUserId, "User id should be cleared");
ok(!provider.synchronizedAuthToken, "Auth token should be cleared"); ok(!provider.synchronizedAuthToken, "Auth token should be cleared");
ok(!provider.synchronizedExpiration, ok(!provider.synchronizedExpiration,
"Expiration should be cleared"); "Expiration should be cleared");
// make sure the auth data is properly deleted
var config = new Config(Parse.applicationId);
config.database.mongoFind('_User', {
_id: model.id
}).then((res) => {
expect(res.length).toBe(1);
expect(res[0]._auth_data_myoauth).toBeUndefined();
expect(res[0]._auth_data_myoauth).not.toBeNull();
model._linkWith("myoauth", { model._linkWith("myoauth", {
success: function(model) { success: function(model) {
ok(provider.synchronizedUserId, "User id should have a value"); ok(provider.synchronizedUserId, "User id should have a value");
ok(provider.synchronizedAuthToken, ok(provider.synchronizedAuthToken,
"Auth token should have a value"); "Auth token should have a value");
ok(provider.synchronizedExpiration, ok(provider.synchronizedExpiration,
"Expiration should have a value"); "Expiration should have a value");
ok(model._isLinked("myoauth"), ok(model._isLinked("myoauth"),
"User should be linked to myoauth"); "User should be linked to myoauth");
done(); done();
}, },
error: function(model, error) { error: function(model, error) {
ok(false, "linking again should succeed"); ok(false, "linking again should succeed");
done(); done();
} }
});
}); });
}, },
error: function(model, error) { error: function(model, error) {

10
src/transform.js
View File

@@ -260,7 +260,14 @@ function transformUpdate(schema, className, restUpdate) {
function transformAuthData(restObject) { function transformAuthData(restObject) {
if (restObject.authData) { if (restObject.authData) {
Object.keys(restObject.authData).forEach((provider) => { Object.keys(restObject.authData).forEach((provider) => {
restObject[`_auth_data_${provider}`] = restObject.authData[provider]; let providerData = restObject.authData[provider];
if (providerData == null) {
restObject[`_auth_data_${provider}`] = {
__op: 'Delete'
}
} else {
restObject[`_auth_data_${provider}`] = providerData;
}
}); });
delete restObject.authData; delete restObject.authData;
} }
@@ -823,4 +830,3 @@ module.exports = {
transformWhere: transformWhere, transformWhere: transformWhere,
untransformObject: untransformObject untransformObject: untransformObject
}; };