Added exception for Twitter and OAuth missing options (#3676)

* Added exception for Twitter and OAuth missing configuration information

* Updated error codes to INTERNAL_SERVER_ERROR, code 1
This commit is contained in:
Benjamin Wilson Friedman
2017-03-28 15:16:47 -07:00
committed by Florent Vilmart
parent a54f4d43fa
commit e01b417d3f
4 changed files with 32 additions and 1 deletions

View File

@@ -133,4 +133,14 @@ describe('OAuth', function() {
done();
})
});
it("Should fail with missing options", (done) => {
var options = undefined;
try {
new OAuth(options);
} catch (error) {
jequal(error.message, 'No options passed to OAuth');
done();
}
});
});

View File

@@ -9,7 +9,7 @@ describe('Twitter Auth', () => {
consumer_key: 'hello'
}, {
consumer_key: 'world'
}]).consumer_key).toEqual('hello')
}]).consumer_key).toEqual('hello');
// Multiple options, consumer_key not found
expect(function(){
@@ -47,4 +47,18 @@ describe('Twitter Auth', () => {
consumer_key: 'hello'
}).consumer_key).toEqual('hello');
});
it("Should fail with missing options", (done) => {
try {
twitter.validateAuthData({
consumer_key: 'key',
consumer_secret: 'secret',
auth_token: 'token',
auth_token_secret: 'secret'
}, undefined);
} catch (error) {
jequal(error.message, 'Twitter auth configuration missing');
done();
}
});
});