Use Prettier JS (#5017)

* Adds prettier

* Run lint before tests

spec/Middlewares.spec.js

@@ -2,7 +2,6 @@ const middlewares = require('../lib/middlewares');
 const AppCache = require('../lib/cache').AppCache;
 
 describe('middlewares', () => {
-
   let fakeReq, fakeRes;
 
   beforeEach(() => {
@@ -10,12 +9,12 @@ describe('middlewares', () => {
       originalUrl: 'http://example.com/parse/',
       url: 'http://example.com/',
       body: {
-        _ApplicationId: 'FakeAppId'
+        _ApplicationId: 'FakeAppId',
       },
       headers: {},
-      get: (key) => {
-        return fakeReq.headers[key.toLowerCase()]
-      }
+      get: key => {
+        return fakeReq.headers[key.toLowerCase()];
+      },
     };
     fakeRes = jasmine.createSpyObj('fakeRes', ['end', 'status']);
     AppCache.put(fakeReq.body._ApplicationId, {});
@@ -25,21 +24,21 @@ describe('middlewares', () => {
     AppCache.del(fakeReq.body._ApplicationId);
   });
 
-  it('should use _ContentType if provided', (done) => {
+  it('should use _ContentType if provided', done => {
     expect(fakeReq.headers['content-type']).toEqual(undefined);
     const contentType = 'image/jpeg';
     fakeReq.body._ContentType = contentType;
     middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeReq.headers['content-type']).toEqual(contentType);
       expect(fakeReq.body._ContentType).toEqual(undefined);
-      done()
+      done();
     });
   });
 
   it('should give invalid response when keys are configured but no key supplied', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      restAPIKey: 'restAPIKey'
+      restAPIKey: 'restAPIKey',
     });
     middlewares.handleParseHeaders(fakeReq, fakeRes);
     expect(fakeRes.status).toHaveBeenCalledWith(403);
@@ -48,7 +47,7 @@ describe('middlewares', () => {
   it('should give invalid response when keys are configured but supplied key is incorrect', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      restAPIKey: 'restAPIKey'
+      restAPIKey: 'restAPIKey',
     });
     fakeReq.headers['x-parse-rest-api-key'] = 'wrongKey';
     middlewares.handleParseHeaders(fakeReq, fakeRes);
@@ -58,19 +57,18 @@ describe('middlewares', () => {
   it('should give invalid response when keys are configured but different key is supplied', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      restAPIKey: 'restAPIKey'
+      restAPIKey: 'restAPIKey',
     });
     fakeReq.headers['x-parse-client-key'] = 'clientKey';
     middlewares.handleParseHeaders(fakeReq, fakeRes);
     expect(fakeRes.status).toHaveBeenCalledWith(403);
   });
 
-
-  it('should succeed when any one of the configured keys supplied', (done) => {
+  it('should succeed when any one of the configured keys supplied', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       clientKey: 'clientKey',
       masterKey: 'masterKey',
-      restAPIKey: 'restAPIKey'
+      restAPIKey: 'restAPIKey',
     });
     fakeReq.headers['x-parse-rest-api-key'] = 'restAPIKey';
     middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
@@ -79,11 +77,11 @@ describe('middlewares', () => {
     });
   });
 
-  it('should succeed when client key supplied but empty', (done) => {
+  it('should succeed when client key supplied but empty', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       clientKey: '',
       masterKey: 'masterKey',
-      restAPIKey: 'restAPIKey'
+      restAPIKey: 'restAPIKey',
     });
     fakeReq.headers['x-parse-client-key'] = '';
     middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
@@ -92,9 +90,9 @@ describe('middlewares', () => {
     });
   });
 
-  it('should succeed when no keys are configured and none supplied', (done) => {
+  it('should succeed when no keys are configured and none supplied', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
-      masterKey: 'masterKey'
+      masterKey: 'masterKey',
     });
     middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
@@ -107,25 +105,27 @@ describe('middlewares', () => {
     installationId: '_InstallationId',
     sessionToken: '_SessionToken',
     masterKey: '_MasterKey',
-    javascriptKey: '_JavaScriptKey'
+    javascriptKey: '_JavaScriptKey',
   };
 
   const BodyKeys = Object.keys(BodyParams);
 
-  BodyKeys.forEach((infoKey) => {
+  BodyKeys.forEach(infoKey => {
     const bodyKey = BodyParams[infoKey];
     const keyValue = 'Fake' + bodyKey;
     // javascriptKey is the only one that gets defaulted,
-    const otherKeys = BodyKeys.filter((otherKey) => otherKey !== infoKey && otherKey !== 'javascriptKey');
+    const otherKeys = BodyKeys.filter(
+      otherKey => otherKey !== infoKey && otherKey !== 'javascriptKey'
+    );
 
-    it(`it should pull ${bodyKey} into req.info`, (done) => {
+    it(`it should pull ${bodyKey} into req.info`, done => {
       fakeReq.body[bodyKey] = keyValue;
 
       middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
         expect(fakeReq.body[bodyKey]).toEqual(undefined);
         expect(fakeReq.info[infoKey]).toEqual(keyValue);
 
-        otherKeys.forEach((otherKey) => {
+        otherKeys.forEach(otherKey => {
           expect(fakeReq.info[otherKey]).toEqual(undefined);
         });
 
@@ -137,7 +137,7 @@ describe('middlewares', () => {
   it('should not succeed if the ip does not belong to masterKeyIps list', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
     fakeReq.ip = 'ip3';
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
@@ -145,14 +145,14 @@ describe('middlewares', () => {
     expect(fakeRes.status).toHaveBeenCalledWith(403);
   });
 
-  it('should succeed if the ip does belong to masterKeyIps list', (done) => {
+  it('should succeed if the ip does belong to masterKeyIps list', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
     fakeReq.ip = 'ip1';
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
@@ -161,22 +161,22 @@ describe('middlewares', () => {
   it('should not succeed if the connection.remoteAddress does not belong to masterKeyIps list', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
-    fakeReq.connection = {remoteAddress : 'ip3'};
+    fakeReq.connection = { remoteAddress: 'ip3' };
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     middlewares.handleParseHeaders(fakeReq, fakeRes);
     expect(fakeRes.status).toHaveBeenCalledWith(403);
   });
 
-  it('should succeed if the connection.remoteAddress does belong to masterKeyIps list', (done) => {
+  it('should succeed if the connection.remoteAddress does belong to masterKeyIps list', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
-    fakeReq.connection = {remoteAddress : 'ip1'};
+    fakeReq.connection = { remoteAddress: 'ip1' };
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
@@ -185,22 +185,22 @@ describe('middlewares', () => {
   it('should not succeed if the socket.remoteAddress does not belong to masterKeyIps list', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
-    fakeReq.socket = {remoteAddress : 'ip3'};
+    fakeReq.socket = { remoteAddress: 'ip3' };
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     middlewares.handleParseHeaders(fakeReq, fakeRes);
     expect(fakeRes.status).toHaveBeenCalledWith(403);
   });
 
-  it('should succeed if the socket.remoteAddress does belong to masterKeyIps list', (done) => {
+  it('should succeed if the socket.remoteAddress does belong to masterKeyIps list', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
-    fakeReq.socket = {remoteAddress : 'ip1'};
+    fakeReq.socket = { remoteAddress: 'ip1' };
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
@@ -209,61 +209,61 @@ describe('middlewares', () => {
   it('should not succeed if the connection.socket.remoteAddress does not belong to masterKeyIps list', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
-    fakeReq.connection = { socket : {remoteAddress : 'ip3'}};
+    fakeReq.connection = { socket: { remoteAddress: 'ip3' } };
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     middlewares.handleParseHeaders(fakeReq, fakeRes);
     expect(fakeRes.status).toHaveBeenCalledWith(403);
   });
 
-  it('should succeed if the connection.socket.remoteAddress does belong to masterKeyIps list', (done) => {
+  it('should succeed if the connection.socket.remoteAddress does belong to masterKeyIps list', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1','ip2']
+      masterKeyIps: ['ip1', 'ip2'],
     });
-    fakeReq.connection = { socket : {remoteAddress : 'ip1'}};
+    fakeReq.connection = { socket: { remoteAddress: 'ip1' } };
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
   });
 
-  it('should allow any ip to use masterKey if masterKeyIps is empty', (done) => {
+  it('should allow any ip to use masterKey if masterKeyIps is empty', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: []
+      masterKeyIps: [],
     });
     fakeReq.ip = 'ip1';
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
   });
 
-  it('should succeed if xff header does belong to masterKeyIps', (done) => {
+  it('should succeed if xff header does belong to masterKeyIps', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1']
+      masterKeyIps: ['ip1'],
     });
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     fakeReq.headers['x-forwarded-for'] = 'ip1, ip2, ip3';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
   });
 
-  it('should succeed if xff header with one ip does belong to masterKeyIps', (done) => {
+  it('should succeed if xff header with one ip does belong to masterKeyIps', done => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1']
+      masterKeyIps: ['ip1'],
     });
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     fakeReq.headers['x-forwarded-for'] = 'ip1';
-    middlewares.handleParseHeaders(fakeReq, fakeRes,() => {
+    middlewares.handleParseHeaders(fakeReq, fakeRes, () => {
       expect(fakeRes.status).not.toHaveBeenCalled();
       done();
     });
@@ -272,7 +272,7 @@ describe('middlewares', () => {
   it('should not succeed if xff header does not belong to masterKeyIps', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip4']
+      masterKeyIps: ['ip4'],
     });
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     fakeReq.headers['x-forwarded-for'] = 'ip1, ip2, ip3';
@@ -283,7 +283,7 @@ describe('middlewares', () => {
   it('should not succeed if xff header is empty and masterKeyIps is set', () => {
     AppCache.put(fakeReq.body._ApplicationId, {
       masterKey: 'masterKey',
-      masterKeyIps: ['ip1']
+      masterKeyIps: ['ip1'],
     });
     fakeReq.headers['x-parse-master-key'] = 'masterKey';
     fakeReq.headers['x-forwarded-for'] = '';
@@ -295,11 +295,13 @@ describe('middlewares', () => {
     const headers = {};
     const res = {
       header: (key, value) => {
-        headers[key] = value
-      }
+        headers[key] = value;
+      },
     };
     middlewares.allowCrossDomain({}, res, () => {});
     expect(Object.keys(headers).length).toBe(4);
-    expect(headers['Access-Control-Expose-Headers']).toBe('X-Parse-Job-Status-Id, X-Parse-Push-Status-Id');
+    expect(headers['Access-Control-Expose-Headers']).toBe(
+      'X-Parse-Job-Status-Id, X-Parse-Push-Status-Id'
+    );
   });
 });