Use Prettier JS (#5017)

* Adds prettier

* Run lint before tests
This commit is contained in:
Florent Vilmart
2018-09-01 13:58:06 -04:00
committed by GitHub
parent 189cd259ee
commit d83a0b6808
240 changed files with 41098 additions and 29020 deletions

View File

@@ -2,22 +2,24 @@
const request = require('request');
const LogsRouter = require('../lib/Routers/LogsRouter').LogsRouter;
const LoggerController = require('../lib/Controllers/LoggerController').LoggerController;
const WinstonLoggerAdapter = require('../lib/Adapters/Logger/WinstonLoggerAdapter').WinstonLoggerAdapter;
const LoggerController = require('../lib/Controllers/LoggerController')
.LoggerController;
const WinstonLoggerAdapter = require('../lib/Adapters/Logger/WinstonLoggerAdapter')
.WinstonLoggerAdapter;
const loggerController = new LoggerController(new WinstonLoggerAdapter());
describe('LogsRouter', () => {
it('can check valid master key of request', (done) => {
it('can check valid master key of request', done => {
// Make mock request
const request = {
auth: {
isMaster: true
isMaster: true,
},
query: {},
config: {
loggerController: loggerController
}
loggerController: loggerController,
},
};
const router = new LogsRouter();
@@ -28,16 +30,16 @@ describe('LogsRouter', () => {
done();
});
it('can check invalid construction of controller', (done) => {
it('can check invalid construction of controller', done => {
// Make mock request
const request = {
auth: {
isMaster: true
isMaster: true,
},
query: {},
config: {
loggerController: undefined // missing controller
}
loggerController: undefined, // missing controller
},
};
const router = new LogsRouter();
@@ -49,24 +51,27 @@ describe('LogsRouter', () => {
});
it('can check invalid master key of request', done => {
request.get({
url: 'http://localhost:8378/1/scriptlog',
json: true,
headers: {
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
request.get(
{
url: 'http://localhost:8378/1/scriptlog',
json: true,
headers: {
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest',
},
},
(error, response, body) => {
expect(response.statusCode).toEqual(403);
expect(body.error).toEqual('unauthorized: master key is required');
done();
}
}, (error, response, body) => {
expect(response.statusCode).toEqual(403);
expect(body.error).toEqual('unauthorized: master key is required');
done();
});
);
});
const headers = {
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest',
'X-Parse-Master-Key': 'test'
'X-Parse-Master-Key': 'test',
};
/**
@@ -74,24 +79,35 @@ describe('LogsRouter', () => {
*/
it('does scrub simple passwords on GET login', done => {
reconfigureServer({
verbose: true
verbose: true,
}).then(function() {
request.get({
headers: headers,
url: 'http://localhost:8378/1/login?username=test&password=simplepass.com'
}, () => {
request.get({
url: 'http://localhost:8378/1/scriptlog?size=4&level=verbose',
json: true,
headers: headers
}, (error, response, body) => {
expect(response.statusCode).toEqual(200);
// 4th entry is our actual GET request
expect(body[2].url).toEqual('/1/login?username=test&password=********');
expect(body[2].message).toEqual('REQUEST for [GET] /1/login?username=test&password=********: {}');
done();
});
});
request.get(
{
headers: headers,
url:
'http://localhost:8378/1/login?username=test&password=simplepass.com',
},
() => {
request.get(
{
url: 'http://localhost:8378/1/scriptlog?size=4&level=verbose',
json: true,
headers: headers,
},
(error, response, body) => {
expect(response.statusCode).toEqual(200);
// 4th entry is our actual GET request
expect(body[2].url).toEqual(
'/1/login?username=test&password=********'
);
expect(body[2].message).toEqual(
'REQUEST for [GET] /1/login?username=test&password=********: {}'
);
done();
}
);
}
);
});
});
@@ -100,25 +116,36 @@ describe('LogsRouter', () => {
*/
it('does scrub complex passwords on GET login', done => {
reconfigureServer({
verbose: true
verbose: true,
}).then(function() {
request.get({
headers: headers,
// using urlencoded password, 'simple @,/?:&=+$#pass.com'
url: 'http://localhost:8378/1/login?username=test&password=simple%20%40%2C%2F%3F%3A%26%3D%2B%24%23pass.com'
}, () => {
request.get({
url: 'http://localhost:8378/1/scriptlog?size=4&level=verbose',
json: true,
headers: headers
}, (error, response, body) => {
expect(response.statusCode).toEqual(200);
// 4th entry is our actual GET request
expect(body[2].url).toEqual('/1/login?username=test&password=********');
expect(body[2].message).toEqual('REQUEST for [GET] /1/login?username=test&password=********: {}');
done();
});
});
request.get(
{
headers: headers,
// using urlencoded password, 'simple @,/?:&=+$#pass.com'
url:
'http://localhost:8378/1/login?username=test&password=simple%20%40%2C%2F%3F%3A%26%3D%2B%24%23pass.com',
},
() => {
request.get(
{
url: 'http://localhost:8378/1/scriptlog?size=4&level=verbose',
json: true,
headers: headers,
},
(error, response, body) => {
expect(response.statusCode).toEqual(200);
// 4th entry is our actual GET request
expect(body[2].url).toEqual(
'/1/login?username=test&password=********'
);
expect(body[2].message).toEqual(
'REQUEST for [GET] /1/login?username=test&password=********: {}'
);
done();
}
);
}
);
});
});
@@ -127,28 +154,36 @@ describe('LogsRouter', () => {
*/
it('does not have password field in POST login', done => {
reconfigureServer({
verbose: true
verbose: true,
}).then(function() {
request.post({
headers: headers,
url: 'http://localhost:8378/1/login',
data: {
username: 'test',
password: 'simplepass.com'
request.post(
{
headers: headers,
url: 'http://localhost:8378/1/login',
data: {
username: 'test',
password: 'simplepass.com',
},
},
() => {
request.get(
{
url: 'http://localhost:8378/1/scriptlog?size=4&level=verbose',
json: true,
headers: headers,
},
(error, response, body) => {
expect(response.statusCode).toEqual(200);
// 4th entry is our actual GET request
expect(body[2].url).toEqual('/1/login');
expect(body[2].message).toEqual(
'REQUEST for [POST] /1/login: {}'
);
done();
}
);
}
}, () => {
request.get({
url: 'http://localhost:8378/1/scriptlog?size=4&level=verbose',
json: true,
headers: headers
}, (error, response, body) => {
expect(response.statusCode).toEqual(200);
// 4th entry is our actual GET request
expect(body[2].url).toEqual('/1/login');
expect(body[2].message).toEqual('REQUEST for [POST] /1/login: {}');
done();
});
});
);
});
});
});