Use Prettier JS (#5017)

* Adds prettier

* Run lint before tests
This commit is contained in:
Florent Vilmart
2018-09-01 13:58:06 -04:00
committed by GitHub
parent 189cd259ee
commit d83a0b6808
240 changed files with 41098 additions and 29020 deletions

View File

@@ -1,15 +1,16 @@
'use strict';
const commander = require('../lib/cli/utils/commander').default;
const definitions = require('../lib/cli/definitions/parse-server').default;
const liveQueryDefinitions = require('../lib/cli/definitions/parse-live-query-server').default;
const liveQueryDefinitions = require('../lib/cli/definitions/parse-live-query-server')
.default;
const testDefinitions = {
'arg0': 'PROGRAM_ARG_0',
'arg1': {
arg0: 'PROGRAM_ARG_0',
arg1: {
env: 'PROGRAM_ARG_1',
required: true
required: true,
},
'arg2': {
arg2: {
env: 'PROGRAM_ARG_2',
action: function(value) {
const intValue = parseInt(value);
@@ -17,16 +18,16 @@ const testDefinitions = {
throw 'arg2 is invalid';
}
return intValue;
}
},
},
arg3: {},
arg4: {
default: 'arg4Value',
},
'arg3': {},
'arg4': {
default: 'arg4Value'
}
};
describe('commander additions', () => {
afterEach((done) => {
afterEach(done => {
commander.options = [];
delete commander.arg0;
delete commander.arg1;
@@ -36,9 +37,20 @@ describe('commander additions', () => {
done();
});
it('should load properly definitions from args', (done) => {
it('should load properly definitions from args', done => {
commander.loadDefinitions(testDefinitions);
commander.parse(['node','./CLI.spec.js','--arg0', 'arg0Value', '--arg1', 'arg1Value', '--arg2', '2', '--arg3', 'some']);
commander.parse([
'node',
'./CLI.spec.js',
'--arg0',
'arg0Value',
'--arg1',
'arg1Value',
'--arg2',
'2',
'--arg3',
'some',
]);
expect(commander.arg0).toEqual('arg0Value');
expect(commander.arg1).toEqual('arg1Value');
expect(commander.arg2).toEqual(2);
@@ -47,12 +59,12 @@ describe('commander additions', () => {
done();
});
it('should load properly definitions from env', (done) => {
it('should load properly definitions from env', done => {
commander.loadDefinitions(testDefinitions);
commander.parse([], {
'PROGRAM_ARG_0': 'arg0ENVValue',
'PROGRAM_ARG_1': 'arg1ENVValue',
'PROGRAM_ARG_2': '3',
PROGRAM_ARG_0: 'arg0ENVValue',
PROGRAM_ARG_1: 'arg1ENVValue',
PROGRAM_ARG_2: '3',
});
expect(commander.arg0).toEqual('arg0ENVValue');
expect(commander.arg1).toEqual('arg1ENVValue');
@@ -61,14 +73,17 @@ describe('commander additions', () => {
done();
});
it('should load properly use args over env', (done) => {
it('should load properly use args over env', done => {
commander.loadDefinitions(testDefinitions);
commander.parse(['node','./CLI.spec.js','--arg0', 'arg0Value', '--arg4', ''], {
'PROGRAM_ARG_0': 'arg0ENVValue',
'PROGRAM_ARG_1': 'arg1ENVValue',
'PROGRAM_ARG_2': '4',
'PROGRAM_ARG_4': 'arg4ENVValue'
});
commander.parse(
['node', './CLI.spec.js', '--arg0', 'arg0Value', '--arg4', ''],
{
PROGRAM_ARG_0: 'arg0ENVValue',
PROGRAM_ARG_1: 'arg1ENVValue',
PROGRAM_ARG_2: '4',
PROGRAM_ARG_4: 'arg4ENVValue',
}
);
expect(commander.arg0).toEqual('arg0Value');
expect(commander.arg1).toEqual('arg1ENVValue');
expect(commander.arg2).toEqual(4);
@@ -76,24 +91,33 @@ describe('commander additions', () => {
done();
});
it('should fail in action as port is invalid', (done) => {
it('should fail in action as port is invalid', done => {
commander.loadDefinitions(testDefinitions);
expect(()=> {
commander.parse(['node','./CLI.spec.js','--arg0', 'arg0Value'], {
'PROGRAM_ARG_0': 'arg0ENVValue',
'PROGRAM_ARG_1': 'arg1ENVValue',
'PROGRAM_ARG_2': 'hello',
expect(() => {
commander.parse(['node', './CLI.spec.js', '--arg0', 'arg0Value'], {
PROGRAM_ARG_0: 'arg0ENVValue',
PROGRAM_ARG_1: 'arg1ENVValue',
PROGRAM_ARG_2: 'hello',
});
}).toThrow('arg2 is invalid');
done();
});
it('should not override config.json', (done) => {
it('should not override config.json', done => {
commander.loadDefinitions(testDefinitions);
commander.parse(['node','./CLI.spec.js','--arg0', 'arg0Value', './spec/configs/CLIConfig.json'], {
'PROGRAM_ARG_0': 'arg0ENVValue',
'PROGRAM_ARG_1': 'arg1ENVValue',
});
commander.parse(
[
'node',
'./CLI.spec.js',
'--arg0',
'arg0Value',
'./spec/configs/CLIConfig.json',
],
{
PROGRAM_ARG_0: 'arg0ENVValue',
PROGRAM_ARG_1: 'arg1ENVValue',
}
);
const options = commander.getOptions();
expect(options.arg2).toBe(8888);
expect(options.arg3).toBe('hello'); //config value
@@ -101,28 +125,45 @@ describe('commander additions', () => {
done();
});
it('should fail with invalid values in JSON', (done) => {
it('should fail with invalid values in JSON', done => {
commander.loadDefinitions(testDefinitions);
expect(() => {
commander.parse(['node','./CLI.spec.js','--arg0', 'arg0Value', './spec/configs/CLIConfigFail.json'], {
'PROGRAM_ARG_0': 'arg0ENVValue',
'PROGRAM_ARG_1': 'arg1ENVValue',
});
commander.parse(
[
'node',
'./CLI.spec.js',
'--arg0',
'arg0Value',
'./spec/configs/CLIConfigFail.json',
],
{
PROGRAM_ARG_0: 'arg0ENVValue',
PROGRAM_ARG_1: 'arg1ENVValue',
}
);
}).toThrow('arg2 is invalid');
done();
});
it('should fail when too many apps are set', (done) => {
it('should fail when too many apps are set', done => {
commander.loadDefinitions(testDefinitions);
expect(() => {
commander.parse(['node','./CLI.spec.js','./spec/configs/CLIConfigFailTooManyApps.json']);
commander.parse([
'node',
'./CLI.spec.js',
'./spec/configs/CLIConfigFailTooManyApps.json',
]);
}).toThrow('Multiple apps are not supported');
done();
});
it('should load config from apps', (done) => {
it('should load config from apps', done => {
commander.loadDefinitions(testDefinitions);
commander.parse(['node', './CLI.spec.js', './spec/configs/CLIConfigApps.json']);
commander.parse([
'node',
'./CLI.spec.js',
'./spec/configs/CLIConfigApps.json',
]);
const options = commander.getOptions();
expect(options.arg1).toBe('my_app');
expect(options.arg2).toBe(8888);
@@ -131,10 +172,14 @@ describe('commander additions', () => {
done();
});
it('should fail when passing an invalid arguement', (done) => {
it('should fail when passing an invalid arguement', done => {
commander.loadDefinitions(testDefinitions);
expect(() => {
commander.parse(['node', './CLI.spec.js', './spec/configs/CLIConfigUnknownArg.json']);
commander.parse([
'node',
'./CLI.spec.js',
'./spec/configs/CLIConfigUnknownArg.json',
]);
}).toThrow('error: unknown option myArg');
done();
});
@@ -160,7 +205,7 @@ describe('definitions', () => {
it('should throw when using deprecated facebookAppIds', () => {
expect(() => {
definitions.facebookAppIds.action()
definitions.facebookAppIds.action();
}).toThrow();
});
});
@@ -173,7 +218,10 @@ describe('LiveQuery definitions', () => {
if (typeof definition.env !== 'undefined') {
expect(typeof definition.env).toBe('string');
}
expect(typeof definition.help).toBe('string', `help for ${key} should be a string`);
expect(typeof definition.help).toBe(
'string',
`help for ${key} should be a string`
);
if (typeof definition.required !== 'undefined') {
expect(typeof definition.required).toBe('boolean');
}