joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable prefer-const lint rule (#3202)

Browse Source
This commit is contained in:
Arthur Cinader
2016-12-07 15:17:05 -08:00
committed by Florent Vilmart
parent a6c988176e
commit ca286b7108
106 changed files with 1183 additions and 1183 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Routers/ClassesRouter.js
View File

@@ -9,12 +9,12 @@ const ALLOWED_GET_QUERY_KEYS = ['keys', 'include'];
export class ClassesRouter extends PromiseRouter {
handleFind(req) {
let body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query));
let options = {};
let allowConstraints = ['skip', 'limit', 'order', 'count', 'keys',
const body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query));
const options = {};
const allowConstraints = ['skip', 'limit', 'order', 'count', 'keys',
'include', 'redirectClassNameForKey', 'where'];
for (let key of Object.keys(body)) {
for (const key of Object.keys(body)) {
if (allowConstraints.indexOf(key) === -1) {
throw new Parse.Error(Parse.Error.INVALID_QUERY, `Invalid parameter for query: ${key}`);
}
@@ -49,7 +49,7 @@ export class ClassesRouter extends PromiseRouter {
return rest.find(req.config, req.auth, req.params.className, body.where, options, req.info.clientSDK)
.then((response) => {
if (response && response.results) {
for (let result of response.results) {
for (const result of response.results) {
if (result.sessionToken) {
result.sessionToken = req.info.sessionToken || result.sessionToken;
}
@@ -61,10 +61,10 @@ export class ClassesRouter extends PromiseRouter {
// Returns a promise for a {response} object.
handleGet(req) {
let body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query));
let options = {};
const body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query));
const options = {};
for (let key of Object.keys(body)) {
for (const key of Object.keys(body)) {
if (ALLOWED_GET_QUERY_KEYS.indexOf(key) === -1) {
throw new Parse.Error(Parse.Error.INVALID_QUERY, 'Improper encode of parameter');
}
@@ -114,8 +114,8 @@ export class ClassesRouter extends PromiseRouter {
}
static JSONFromQuery(query) {
let json = {};
for (let [key, value] of _.entries(query)) {
const json = {};
for (const [key, value] of _.entries(query)) {
try {
json[key] = JSON.parse(value);
} catch (e) {

4
src/Routers/CloudCodeRouter.js
View File

@@ -7,8 +7,8 @@ export class CloudCodeRouter extends PromiseRouter {
}
static getJobs(req) {
let config = req.config;
let jobs = triggers.getJobs(config.applicationId) || {};
const config = req.config;
const jobs = triggers.getJobs(config.applicationId) || {};
return Promise.resolve({
response: Object.keys(jobs).map((jobName) => {
return {

4
src/Routers/GlobalConfigRouter.js
View File

@@ -10,13 +10,13 @@ export class GlobalConfigRouter extends PromiseRouter {
// If there is no config in the database - return empty config.
return { response: { params: {} } };
}
let globalConfig = results[0];
const globalConfig = results[0];
return { response: { params: globalConfig.params } };
});
}
updateGlobalConfig(req) {
let params = req.body.params;
const params = req.body.params;
// Transform in dot notation to make sure it works
const update = Object.keys(params).reduce((acc, key) => {
acc[`params.${key}`] = params[key];

2
src/Routers/InstallationsRouter.js
View File

@@ -5,7 +5,7 @@ import rest from '../rest';
export class InstallationsRouter extends ClassesRouter {
handleFind(req) {
let body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query));
const body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query));
var options = {};
if (body.skip) {

32
src/Routers/PublicAPIRouter.js
View File

@@ -5,15 +5,15 @@ import path from 'path';
import fs from 'fs';
import qs from 'querystring';
let public_html = path.resolve(__dirname, "../../public_html");
let views = path.resolve(__dirname, '../../views');
const public_html = path.resolve(__dirname, "../../public_html");
const views = path.resolve(__dirname, '../../views');
export class PublicAPIRouter extends PromiseRouter {
verifyEmail(req) {
let { token, username }= req.query;
let appId = req.params.appId;
let config = new Config(appId);
const { token, username } = req.query;
const appId = req.params.appId;
const config = new Config(appId);
if (!config.publicServerURL) {
return this.missingPublicServerURL();
@@ -23,9 +23,9 @@ export class PublicAPIRouter extends PromiseRouter {
return this.invalidLink(req);
}
let userController = config.userController;
const userController = config.userController;
return userController.verifyEmail(username, token).then(() => {
let params = qs.stringify({username});
const params = qs.stringify({username});
return Promise.resolve({
status: 302,
location: `${config.verifyEmailSuccessURL}?${params}`
@@ -37,7 +37,7 @@ export class PublicAPIRouter extends PromiseRouter {
changePassword(req) {
return new Promise((resolve, reject) => {
let config = new Config(req.query.id);
const config = new Config(req.query.id);
if (!config.publicServerURL) {
return resolve({
status: 404,
@@ -59,20 +59,20 @@ export class PublicAPIRouter extends PromiseRouter {
requestResetPassword(req) {
let config = req.config;
const config = req.config;
if (!config.publicServerURL) {
return this.missingPublicServerURL();
}
let { username, token } = req.query;
const { username, token } = req.query;
if (!username || !token) {
return this.invalidLink(req);
}
return config.userController.checkResetTokenValidity(username, token).then(() => {
let params = qs.stringify({token, id: config.applicationId, username, app: config.appName, });
const params = qs.stringify({token, id: config.applicationId, username, app: config.appName, });
return Promise.resolve({
status: 302,
location: `${config.choosePasswordURL}?${params}`
@@ -84,13 +84,13 @@ export class PublicAPIRouter extends PromiseRouter {
resetPassword(req) {
let config = req.config;
const config = req.config;
if (!config.publicServerURL) {
return this.missingPublicServerURL();
}
let {
const {
username,
token,
new_password
@@ -101,13 +101,13 @@ export class PublicAPIRouter extends PromiseRouter {
}
return config.userController.updatePassword(username, token, new_password).then(() => {
let params = qs.stringify({username: username});
const params = qs.stringify({username: username});
return Promise.resolve({
status: 302,
location: `${config.passwordResetSuccessURL}?${params}`
});
}, (err) => {
let params = qs.stringify({username: username, token: token, id: config.applicationId, error:err, app:config.appName})
const params = qs.stringify({username: username, token: token, id: config.applicationId, error:err, app:config.appName})
return Promise.resolve({
status: 302,
location: `${config.choosePasswordURL}?${params}`
@@ -153,7 +153,7 @@ export class PublicAPIRouter extends PromiseRouter {
}
expressRouter() {
let router = express.Router();
const router = express.Router();
router.use("/apps", express.static(public_html));
router.use("/", super.expressRouter());
return router;

10
src/Routers/PushRouter.js
View File

@@ -14,9 +14,9 @@ export class PushRouter extends PromiseRouter {
throw new Parse.Error(Parse.Error.PUSH_MISCONFIGURED, 'Push controller is not set');
}
let where = PushRouter.getQueryCondition(req);
const where = PushRouter.getQueryCondition(req);
let resolve;
let promise = new Promise((_resolve) => {
const promise = new Promise((_resolve) => {
resolve = _resolve;
});
pushController.sendPush(req.body, where, req.config, req.auth, (pushStatusId) => {
@@ -38,9 +38,9 @@ export class PushRouter extends PromiseRouter {
* @returns {Object} The query condition, the where field in a query api call
*/
static getQueryCondition(req) {
let body = req.body || {};
let hasWhere = typeof body.where !== 'undefined';
let hasChannels = typeof body.channels !== 'undefined';
const body = req.body || {};
const hasWhere = typeof body.where !== 'undefined';
const hasChannels = typeof body.channels !== 'undefined';
let where;
if (hasWhere && hasChannels) {

4
src/Routers/SchemasRouter.js
View File

@@ -55,8 +55,8 @@ function modifySchema(req) {
return classNameMismatchResponse(req.body.className, req.params.className);
}
let submittedFields = req.body.fields || {};
let className = req.params.className;
const submittedFields = req.body.fields || {};
const className = req.params.className;
return req.config.database.loadSchema({ clearCache: true})
.then(schema => schema.updateClass(className, submittedFields, req.body.classLevelPermissions, req.config.database))

24
src/Routers/UsersRouter.js
View File

@@ -9,7 +9,7 @@ import rest from '../rest';
import Auth from '../Auth';
import passwordCrypto from '../password';
import RestWrite from '../RestWrite';
let cryptoUtils = require('../cryptoUtils');
const cryptoUtils = require('../cryptoUtils');
export class UsersRouter extends ClassesRouter {
handleFind(req) {
@@ -23,7 +23,7 @@ export class UsersRouter extends ClassesRouter {
}
handleCreate(req) {
let data = deepcopy(req.body);
const data = deepcopy(req.body);
req.body = data;
req.params.className = '_User';
@@ -44,7 +44,7 @@ export class UsersRouter extends ClassesRouter {
if (!req.info || !req.info.sessionToken) {
throw new Parse.Error(Parse.Error.INVALID_SESSION_TOKEN, 'invalid session token');
}
let sessionToken = req.info.sessionToken;
const sessionToken = req.info.sessionToken;
return rest.find(req.config, Auth.master(req.config), '_Session',
{ sessionToken },
{ include: 'user' }, req.info.clientSDK)
@@ -54,7 +54,7 @@ export class UsersRouter extends ClassesRouter {
!response.results[0].user) {
throw new Parse.Error(Parse.Error.INVALID_SESSION_TOKEN, 'invalid session token');
} else {
let user = response.results[0].user;
const user = response.results[0].user;
// Send token back on the login, because SDKs expect that.
user.sessionToken = sessionToken;
return { response: user };
@@ -96,7 +96,7 @@ export class UsersRouter extends ClassesRouter {
})
.then((correct) => {
isValidPassword = correct;
let accountLockoutPolicy = new AccountLockout(user, req.config);
const accountLockoutPolicy = new AccountLockout(user, req.config);
return accountLockoutPolicy.handleLoginAttempt(isValidPassword);
})
.then(() => {
@@ -126,7 +126,7 @@ export class UsersRouter extends ClassesRouter {
}
}
let token = 'r:' + cryptoUtils.newToken();
const token = 'r:' + cryptoUtils.newToken();
user.sessionToken = token;
delete user.password;
@@ -145,8 +145,8 @@ export class UsersRouter extends ClassesRouter {
req.config.filesController.expandFilesInObject(req.config, user);
let expiresAt = req.config.generateSessionExpiresAt();
let sessionData = {
const expiresAt = req.config.generateSessionExpiresAt();
const sessionData = {
sessionToken: token,
user: {
__type: 'Pointer',
@@ -165,7 +165,7 @@ export class UsersRouter extends ClassesRouter {
sessionData.installationId = req.info.installationId
}
let create = new RestWrite(req.config, Auth.master(req.config), '_Session', null, sessionData);
const create = new RestWrite(req.config, Auth.master(req.config), '_Session', null, sessionData);
return create.execute();
}).then(() => {
return { response: user };
@@ -173,7 +173,7 @@ export class UsersRouter extends ClassesRouter {
}
handleLogOut(req) {
let success = {response: {}};
const success = {response: {}};
if (req.info && req.info.sessionToken) {
return rest.find(req.config, Auth.master(req.config), '_Session',
{ sessionToken: req.info.sessionToken }, undefined, req.info.clientSDK
@@ -207,14 +207,14 @@ export class UsersRouter extends ClassesRouter {
throw e;
}
}
let { email } = req.body;
const { email } = req.body;
if (!email) {
throw new Parse.Error(Parse.Error.EMAIL_MISSING, "you must provide an email");
}
if (typeof email !== 'string') {
throw new Parse.Error(Parse.Error.INVALID_EMAIL_ADDRESS, 'you must provide a valid email string');
}
let userController = req.config.userController;
const userController = req.config.userController;
return userController.sendPasswordResetEmail(email).then(() => {
return Promise.resolve({
response: {}