joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable prefer-const lint rule (#3202)

Browse Source
This commit is contained in:
Arthur Cinader
2016-12-07 15:17:05 -08:00
committed by Florent Vilmart
parent a6c988176e
commit ca286b7108
106 changed files with 1183 additions and 1183 deletions
Download Patch File Download Diff File Expand all files Collapse all files

178
spec/ParseAPI.spec.js
View File

@@ -5,7 +5,7 @@
var request = require('request');
const rp = require('request-promise');
const Parse = require("parse/node");
let Config = require('../src/Config');
const Config = require('../src/Config');
const SchemaController = require('../src/Controllers/SchemaController');
var TestUtils = require('../src/TestUtils');
@@ -23,7 +23,7 @@ describe_only_db('mongo')('miscellaneous', () => {
obj.set('foo', 'bar');
return obj.save();
}).then(() => {
let config = new Config(appId);
const config = new Config(appId);
return config.database.adapter.find('TestObject', { fields: {} }, {}, {});
}).then((results) => {
expect(results.length).toEqual(1);
@@ -83,7 +83,7 @@ describe('miscellaneous', function() {
it('fail to create a duplicate username', done => {
let numCreated = 0;
let numFailed = 0;
let p1 = createTestUser();
const p1 = createTestUser();
p1.then(() => {
numCreated++;
expect(numCreated).toEqual(1);
@@ -93,7 +93,7 @@ describe('miscellaneous', function() {
expect(numFailed).toEqual(1);
expect(error.code).toEqual(Parse.Error.USERNAME_TAKEN);
});
let p2 = createTestUser();
const p2 = createTestUser();
p2.then(() => {
numCreated++;
expect(numCreated).toEqual(1);
@@ -114,11 +114,11 @@ describe('miscellaneous', function() {
it('ensure that email is uniquely indexed', done => {
let numFailed = 0;
let numCreated = 0;
let user1 = new Parse.User();
const user1 = new Parse.User();
user1.setPassword('asdf');
user1.setUsername('u1');
user1.setEmail('dupe@dupe.dupe');
let p1 = user1.signUp();
const p1 = user1.signUp();
p1.then(() => {
numCreated++;
expect(numCreated).toEqual(1);
@@ -128,11 +128,11 @@ describe('miscellaneous', function() {
expect(error.code).toEqual(Parse.Error.EMAIL_TAKEN);
});
let user2 = new Parse.User();
const user2 = new Parse.User();
user2.setPassword('asdf');
user2.setUsername('u2');
user2.setEmail('dupe@dupe.dupe');
let p2 = user2.signUp();
const p2 = user2.signUp();
p2.then(() => {
numCreated++;
expect(numCreated).toEqual(1);
@@ -151,7 +151,7 @@ describe('miscellaneous', function() {
});
it('ensure that if people already have duplicate users, they can still sign up new users', done => {
let config = new Config('test');
const config = new Config('test');
// Remove existing data to clear out unique index
TestUtils.destroyAllDataPermanently()
.then(() => config.database.adapter.createClass('_User', userSchema))
@@ -161,13 +161,13 @@ describe('miscellaneous', function() {
.then(reconfigureServer)
.catch(error => {
expect(error.code).toEqual(Parse.Error.DUPLICATE_VALUE);
let user = new Parse.User();
const user = new Parse.User();
user.setPassword('asdf');
user.setUsername('zxcv');
return user.signUp().catch(fail);
})
.then(() => {
let user = new Parse.User();
const user = new Parse.User();
user.setPassword('asdf');
user.setUsername('u');
return user.signUp()
@@ -183,7 +183,7 @@ describe('miscellaneous', function() {
});
it('ensure that if people already have duplicate emails, they can still sign up new users', done => {
let config = new Config('test');
const config = new Config('test');
// Remove existing data to clear out unique index
TestUtils.destroyAllDataPermanently()
.then(() => config.database.adapter.createClass('_User', userSchema))
@@ -191,14 +191,14 @@ describe('miscellaneous', function() {
.then(() => config.database.adapter.createObject('_User', userSchema, { objectId: 'y', email: 'a@b.c' }))
.then(reconfigureServer)
.catch(() => {
let user = new Parse.User();
const user = new Parse.User();
user.setPassword('asdf');
user.setUsername('qqq');
user.setEmail('unique@unique.unique');
return user.signUp().catch(fail);
})
.then(() => {
let user = new Parse.User();
const user = new Parse.User();
user.setPassword('asdf');
user.setUsername('www');
user.setEmail('a@b.c');
@@ -211,11 +211,11 @@ describe('miscellaneous', function() {
});
it('ensure that if you try to sign up a user with a unique username and email, but duplicates in some other field that has a uniqueness constraint, you get a regular duplicate value error', done => {
let config = new Config('test');
const config = new Config('test');
config.database.adapter.addFieldIfNotExists('_User', 'randomField', { type: 'String' })
.then(() => config.database.adapter.ensureUniqueness('_User', userSchema, ['randomField']))
.then(() => {
let user = new Parse.User();
const user = new Parse.User();
user.setPassword('asdf');
user.setUsername('1');
user.setEmail('1@b.c');
@@ -223,7 +223,7 @@ describe('miscellaneous', function() {
return user.signUp()
})
.then(() => {
let user = new Parse.User();
const user = new Parse.User();
user.setPassword('asdf');
user.setUsername('2');
user.setEmail('2@b.c');
@@ -374,7 +374,7 @@ describe('miscellaneous', function() {
let triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.beforeSave('GameScore', (req, res) => {
let object = req.object;
const object = req.object;
expect(object instanceof Parse.Object).toBeTruthy();
expect(object.get('fooAgain')).toEqual('barAgain');
if (triggerTime == 0) {
@@ -397,7 +397,7 @@ describe('miscellaneous', function() {
res.success();
});
let obj = new Parse.Object('GameScore');
const obj = new Parse.Object('GameScore');
obj.set('foo', 'bar');
obj.set('fooAgain', 'barAgain');
obj.save().then(() => {
@@ -417,13 +417,13 @@ describe('miscellaneous', function() {
let triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.beforeSave('GameScore', (req, res) => {
let object = req.object;
const object = req.object;
object.set('foo', 'bar');
triggerTime++;
res.success(object);
});
let obj = new Parse.Object('GameScore');
const obj = new Parse.Object('GameScore');
obj.set('foo', 'baz');
obj.save().then(() => {
expect(triggerTime).toBe(1);
@@ -439,10 +439,10 @@ describe('miscellaneous', function() {
let triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.beforeSave('GameScore', (req, res) => {
let object = req.object;
const object = req.object;
expect(object instanceof Parse.Object).toBeTruthy();
expect(object.get('fooAgain')).toEqual('barAgain');
let originalObject = req.original;
const originalObject = req.original;
if (triggerTime == 0) {
// No id/createdAt/updatedAt
expect(object.id).toBeUndefined();
@@ -472,7 +472,7 @@ describe('miscellaneous', function() {
res.success();
});
let obj = new Parse.Object('GameScore');
const obj = new Parse.Object('GameScore');
obj.set('foo', 'bar');
obj.set('fooAgain', 'barAgain');
obj.save().then(() => {
@@ -490,13 +490,13 @@ describe('miscellaneous', function() {
});
it('pointer mutation properly saves object', done => {
let className = 'GameScore';
const className = 'GameScore';
Parse.Cloud.beforeSave(className, (req, res) => {
let object = req.object;
const object = req.object;
expect(object instanceof Parse.Object).toBeTruthy();
let child = object.get('child');
const child = object.get('child');
expect(child instanceof Parse.Object).toBeTruthy();
child.set('a', 'b');
child.save().then(() => {
@@ -504,20 +504,20 @@ describe('miscellaneous', function() {
});
});
let obj = new Parse.Object(className);
const obj = new Parse.Object(className);
obj.set('foo', 'bar');
let child = new Parse.Object('Child');
const child = new Parse.Object('Child');
child.save().then(() => {
obj.set('child', child);
return obj.save();
}).then(() => {
let query = new Parse.Query(className);
const query = new Parse.Query(className);
query.include('child');
return query.get(obj.id).then(objAgain => {
expect(objAgain.get('foo')).toEqual('bar');
let childAgain = objAgain.get('child');
const childAgain = objAgain.get('child');
expect(childAgain instanceof Parse.Object).toBeTruthy();
expect(childAgain.get('a')).toEqual('b');
@@ -703,9 +703,9 @@ describe('miscellaneous', function() {
var triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.afterSave('GameScore', function(req, res) {
let object = req.object;
const object = req.object;
expect(object instanceof Parse.Object).toBeTruthy();
let originalObject = req.original;
const originalObject = req.original;
if (triggerTime == 0) {
// Create
expect(object.get('yolo')).toEqual(1);
@@ -740,13 +740,13 @@ describe('miscellaneous', function() {
let triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.beforeSave('GameScore', function(req, res) {
let object = req.object;
const object = req.object;
if (triggerTime == 0) {
let acl = object.getACL();
const acl = object.getACL();
expect(acl.getPublicReadAccess()).toBeTruthy();
expect(acl.getPublicWriteAccess()).toBeTruthy();
} else if (triggerTime == 1) {
let acl = object.getACL();
const acl = object.getACL();
expect(acl.getPublicReadAccess()).toBeFalsy();
expect(acl.getPublicWriteAccess()).toBeTruthy();
} else {
@@ -756,8 +756,8 @@ describe('miscellaneous', function() {
res.success();
});
let obj = new Parse.Object('GameScore');
let acl = new Parse.ACL();
const obj = new Parse.Object('GameScore');
const acl = new Parse.ACL();
acl.setPublicReadAccess(true);
acl.setPublicWriteAccess(true);
obj.setACL(acl);
@@ -779,13 +779,13 @@ describe('miscellaneous', function() {
let triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.afterSave('GameScore', function(req, res) {
let object = req.object;
const object = req.object;
if (triggerTime == 0) {
let acl = object.getACL();
const acl = object.getACL();
expect(acl.getPublicReadAccess()).toBeTruthy();
expect(acl.getPublicWriteAccess()).toBeTruthy();
} else if (triggerTime == 1) {
let acl = object.getACL();
const acl = object.getACL();
expect(acl.getPublicReadAccess()).toBeFalsy();
expect(acl.getPublicWriteAccess()).toBeTruthy();
} else {
@@ -795,8 +795,8 @@ describe('miscellaneous', function() {
res.success();
});
let obj = new Parse.Object('GameScore');
let acl = new Parse.ACL();
const obj = new Parse.Object('GameScore');
const acl = new Parse.ACL();
acl.setPublicReadAccess(true);
acl.setPublicWriteAccess(true);
obj.setACL(acl);
@@ -815,7 +815,7 @@ describe('miscellaneous', function() {
});
it('should return the updated fields on PUT', done => {
let obj = new Parse.Object('GameScore');
const obj = new Parse.Object('GameScore');
obj.save({a:'hello', c: 1, d: ['1'], e:['1'], f:['1','2']}).then(() => {
var headers = {
'Content-Type': 'application/json',
@@ -1037,7 +1037,7 @@ describe('miscellaneous', function() {
});
it('can handle date params in cloud functions (#2214)', done => {
let date = new Date();
const date = new Date();
Parse.Cloud.define('dateFunc', (request, response) => {
expect(request.params.date.__type).toEqual('Date');
expect(request.params.date.iso).toEqual(date.toISOString());
@@ -1133,27 +1133,27 @@ describe('miscellaneous', function() {
});
it('dedupes an installation properly and returns updatedAt', (done) => {
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
};
let data = {
const data = {
'installationId': 'lkjsahdfkjhsdfkjhsdfkjhsdf',
'deviceType': 'embedded'
};
let requestOptions = {
const requestOptions = {
headers: headers,
url: 'http://localhost:8378/1/installations',
body: JSON.stringify(data)
};
request.post(requestOptions, (error, response, body) => {
expect(error).toBe(null);
let b = JSON.parse(body);
const b = JSON.parse(body);
expect(typeof b.objectId).toEqual('string');
request.post(requestOptions, (error, response, body) => {
expect(error).toBe(null);
let b = JSON.parse(body);
const b = JSON.parse(body);
expect(typeof b.updatedAt).toEqual('string');
done();
});
@@ -1161,17 +1161,17 @@ describe('miscellaneous', function() {
});
it('android login providing empty authData block works', (done) => {
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
};
let data = {
const data = {
username: 'pulse1989',
password: 'password1234',
authData: {}
};
let requestOptions = {
const requestOptions = {
headers: headers,
url: 'http://localhost:8378/1/users',
body: JSON.stringify(data)
@@ -1181,7 +1181,7 @@ describe('miscellaneous', function() {
requestOptions.url = 'http://localhost:8378/1/login';
request.get(requestOptions, (error, response, body) => {
expect(error).toBe(null);
let b = JSON.parse(body);
const b = JSON.parse(body);
expect(typeof b['sessionToken']).toEqual('string');
done();
});
@@ -1189,25 +1189,25 @@ describe('miscellaneous', function() {
});
it('gets relation fields', (done) => {
let object = new Parse.Object('AnObject');
let relatedObject = new Parse.Object('RelatedObject');
const object = new Parse.Object('AnObject');
const relatedObject = new Parse.Object('RelatedObject');
Parse.Object.saveAll([object, relatedObject]).then(() => {
object.relation('related').add(relatedObject);
return object.save();
}).then(() => {
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
};
let requestOptions = {
const requestOptions = {
headers: headers,
url: 'http://localhost:8378/1/classes/AnObject',
json: true
};
request.get(requestOptions, (err, res, body) => {
expect(body.results.length).toBe(1);
let result = body.results[0];
const result = body.results[0];
expect(result.related).toEqual({
__type: "Relation",
className: 'RelatedObject'
@@ -1221,20 +1221,20 @@ describe('miscellaneous', function() {
});
it('properly returns incremented values (#1554)', (done) => {
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
};
let requestOptions = {
const requestOptions = {
headers: headers,
url: 'http://localhost:8378/1/classes/AnObject',
json: true
};
let object = new Parse.Object('AnObject');
const object = new Parse.Object('AnObject');
function runIncrement(amount) {
let options = Object.assign({}, requestOptions, {
const options = Object.assign({}, requestOptions, {
body: {
"key": {
__op: 'Increment',
@@ -1266,7 +1266,7 @@ describe('miscellaneous', function() {
})
it('ignores _RevocableSession "header" send by JS SDK', (done) => {
let object = new Parse.Object('AnObject');
const object = new Parse.Object('AnObject');
object.set('a', 'b');
object.save().then(() => {
request.post({
@@ -1285,7 +1285,7 @@ describe('miscellaneous', function() {
expect(body.error).toBeUndefined();
expect(body.results).not.toBeUndefined();
expect(body.results.length).toBe(1);
let result = body.results[0];
const result = body.results[0];
expect(result.a).toBe('b');
done();
})
@@ -1293,7 +1293,7 @@ describe('miscellaneous', function() {
});
it('doesnt convert interior keys of objects that use special names', done => {
let obj = new Parse.Object('Obj');
const obj = new Parse.Object('Obj');
obj.set('val', { createdAt: 'a', updatedAt: 1 });
obj.save()
.then(obj => new Parse.Query('Obj').get(obj.id))
@@ -1361,10 +1361,10 @@ describe('miscellaneous', function() {
});
it('does not change inner objects if the key has the same name as a geopoint field on the class, and the value is an array of length 2, or if the key has the same name as a file field on the class, and the value is a string', done => {
let file = new Parse.File('myfile.txt', { base64: 'eAo=' });
const file = new Parse.File('myfile.txt', { base64: 'eAo=' });
file.save()
.then(f => {
let obj = new Parse.Object('O');
const obj = new Parse.Object('O');
obj.set('fileField', f);
obj.set('geoField', new Parse.GeoPoint(0, 0));
obj.set('innerObj', {
@@ -1387,17 +1387,17 @@ describe('miscellaneous', function() {
});
it('purge all objects in class', (done) => {
let object = new Parse.Object('TestObject');
const object = new Parse.Object('TestObject');
object.set('foo', 'bar');
let object2 = new Parse.Object('TestObject');
const object2 = new Parse.Object('TestObject');
object2.set('alice', 'wonderland');
Parse.Object.saveAll([object, object2])
.then(() => {
let query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
return query.count()
}).then((count) => {
expect(count).toBe(2);
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-Master-Key': 'test'
@@ -1408,7 +1408,7 @@ describe('miscellaneous', function() {
json: true
}, (err) => {
expect(err).toBe(null);
let query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
return query.count().then((count) => {
expect(count).toBe(0);
done();
@@ -1418,7 +1418,7 @@ describe('miscellaneous', function() {
});
it('fail on purge all objects in class without master key', (done) => {
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
@@ -1437,7 +1437,7 @@ describe('miscellaneous', function() {
});
it('purge all objects in _Role also purge cache', (done) => {
let headers = {
const headers = {
'Content-Type': 'application/json',
'X-Parse-Application-Id': 'test',
'X-Parse-Master-Key': 'test'
@@ -1445,26 +1445,26 @@ describe('miscellaneous', function() {
var user, object;
createTestUser().then((x) => {
user = x;
let acl = new Parse.ACL();
const acl = new Parse.ACL();
acl.setPublicReadAccess(true);
acl.setPublicWriteAccess(false);
let role = new Parse.Object('_Role');
const role = new Parse.Object('_Role');
role.set('name', 'TestRole');
role.setACL(acl);
let users = role.relation('users');
const users = role.relation('users');
users.add(user);
return role.save({}, { useMasterKey: true });
}).then(() => {
let query = new Parse.Query('_Role');
const query = new Parse.Query('_Role');
return query.find({ useMasterKey: true });
}).then((x) => {
expect(x.length).toEqual(1);
let relation = x[0].relation('users').query();
const relation = x[0].relation('users').query();
return relation.first({ useMasterKey: true });
}).then((x) => {
expect(x.id).toEqual(user.id);
object = new Parse.Object('TestObject');
let acl = new Parse.ACL();
const acl = new Parse.ACL();
acl.setPublicReadAccess(false);
acl.setPublicWriteAccess(false);
acl.setRoleReadAccess('TestRole', true);
@@ -1472,7 +1472,7 @@ describe('miscellaneous', function() {
object.setACL(acl);
return object.save();
}).then(() => {
let query = new Parse.Query('TestObject');
const query = new Parse.Query('TestObject');
return query.find({ sessionToken: user.getSessionToken() });
}).then((x) => {
expect(x.length).toEqual(1);
@@ -1483,7 +1483,7 @@ describe('miscellaneous', function() {
json: true
});
}).then(() => {
let query = new Parse.Query('TestObject');
const query = new Parse.Query('TestObject');
return query.get(object.id, { sessionToken: user.getSessionToken() });
}).then(() => {
fail('Should not succeed');
@@ -1502,7 +1502,7 @@ describe('miscellaneous', function() {
response.success();
});
let object = new Parse.Object('MyObject');
const object = new Parse.Object('MyObject');
object.set('key', 'value');
object.save().then(() => {
return object.save({'secret': 'should not update schema'});
@@ -1520,7 +1520,7 @@ describe('miscellaneous', function() {
json: true
});
}).then((res) => {
let fields = res.fields;
const fields = res.fields;
expect(fields.secret).toBeUndefined();
done();
}, (err) => {
@@ -1532,7 +1532,7 @@ describe('miscellaneous', function() {
describe_only_db('mongo')('legacy _acl', () => {
it('should have _acl when locking down (regression for #2465)', (done) => {
let headers = {
const headers = {
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest'
}
@@ -1546,13 +1546,13 @@ describe_only_db('mongo')('legacy _acl', () => {
},
json: true
}).then(() => {
let config = new Config('test');
let adapter = config.database.adapter;
const config = new Config('test');
const adapter = config.database.adapter;
return adapter._adaptiveCollection("Report")
.then(collection => collection.find({}))
}).then((results) => {
expect(results.length).toBe(1);
let result = results[0];
const result = results[0];
expect(result.name).toEqual('My Report');
expect(result._wperm).toEqual([]);
expect(result._rperm).toEqual([]);