From c5e3be8b648419313a7b07d6258f43b1e5ffac7d Mon Sep 17 00:00:00 2001 From: Tyler Brock Date: Thu, 26 May 2016 15:33:37 -0700 Subject: [PATCH] Strip objectId out of responses from HooksController (#1925) --- spec/ParseHooks.spec.js | 4 ++++ src/Controllers/HooksController.js | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/spec/ParseHooks.spec.js b/spec/ParseHooks.spec.js index 1216c560..eba40b06 100644 --- a/spec/ParseHooks.spec.js +++ b/spec/ParseHooks.spec.js @@ -46,10 +46,12 @@ describe('Hooks', () => { // Find return Parse.Hooks.getFunction("My-Test-Function") }).then(response => { + expect(response.objectId).toBeUndefined(); expect(response.url).toBe("http://someurl"); return Parse.Hooks.updateFunction("My-Test-Function", "http://anotherurl"); }) .then((res) => { + expect(res.objectId).toBeUndefined(); expect(res.functionName).toBe("My-Test-Function"); expect(res.url).toBe("http://anotherurl") // delete @@ -90,6 +92,7 @@ describe('Hooks', () => { }).then((res) => { expect(res).not.toBe(null); expect(res).not.toBe(undefined); + expect(res.objectId).toBeUndefined(); expect(res.url).toBe("http://someurl"); // delete return Parse.Hooks.updateTrigger("MyClass","beforeDelete", "http://anotherurl"); @@ -99,6 +102,7 @@ describe('Hooks', () => { }).then((res) => { expect(res.className).toBe("MyClass"); expect(res.url).toBe("http://anotherurl") + expect(res.objectId).toBeUndefined(); return Parse.Hooks.deleteTrigger("MyClass","beforeDelete"); }, (err) => { diff --git a/src/Controllers/HooksController.js b/src/Controllers/HooksController.js index 73cdf172..636c9ada 100644 --- a/src/Controllers/HooksController.js +++ b/src/Controllers/HooksController.js @@ -57,7 +57,12 @@ export class HooksController { _getHooks(query = {}, limit) { let options = limit ? { limit: limit } : undefined; - return this.database.find(DefaultHooksCollectionName, query); + return this.database.find(DefaultHooksCollectionName, query).then((results) => { + return results.map((result) => { + delete result.objectId; + return result; + }); + }); } _removeHooks(query) {