Add circular dependency detection to CI (#7316)

* add circular dependency detection to CI

* fixed Auth-RestWrite circular dependency

* updated package lock

* fixed Logger circular dependency

* fix lint

src/Controllers/AdaptableController.js

@@ -10,7 +10,6 @@ based on the parameters passed
 
 // _adapter is private, use Symbol
 var _adapter = Symbol();
-import Config from '../Config';
 
 export class AdaptableController {
   constructor(adapter, appId, options) {
@@ -28,10 +27,6 @@ export class AdaptableController {
     return this[_adapter];
   }
 
-  get config() {
-    return Config.get(this.appId);
-  }
-
   expectedAdapterType() {
     throw new Error('Subclasses should implement expectedAdapterType()');
   }

src/Controllers/UserController.js

@@ -5,6 +5,7 @@ import MailAdapter from '../Adapters/Email/MailAdapter';
 import rest from '../rest';
 import Parse from 'parse/node';
 import AccountLockout from '../AccountLockout';
+import Config from '../Config';
 
 var RestQuery = require('../RestQuery');
 var Auth = require('../Auth');
@@ -14,6 +15,10 @@ export class UserController extends AdaptableController {
     super(adapter, appId, options);
   }
 
+  get config() {
+    return Config.get(this.appId);
+  }
+
   validateAdapter(adapter) {
     // Allow no adapter
     if (!adapter && !this.shouldVerifyEmails) {