Validation Handler Update (#6968)

* Initial Commit

* Update FunctionsRouter.js

* Update FunctionsRouter.js

* Change params to fields

* Changes requested

* Fix failing tests

* More tests

* More tests

* Remove existing functionality

* Remove legacy tests

* fix array typo

* Update triggers.js

* Docs

* Allow requireUserKeys to be object

* validateMasterKey

* Improve documentation

Co-authored-by: Diamond Lewis <findlewis@gmail.com>

spec/ParseLiveQuery.spec.js

@@ -2,6 +2,10 @@
 const UserController = require('../lib/Controllers/UserController')
   .UserController;
 const Config = require('../lib/Config');
+const validatorFail = () => {
+  throw 'you are not authorized';
+};
+
 describe('ParseLiveQuery', function () {
   it('can subscribe to query', async done => {
     await reconfigureServer({
@@ -231,6 +235,7 @@ describe('ParseLiveQuery', function () {
     object.set({ foo: 'bar' });
     await object.save();
   });
+
   it('can handle afterEvent throw', async done => {
     await reconfigureServer({
       liveQuery: {
@@ -300,6 +305,7 @@ describe('ParseLiveQuery', function () {
     object.set({ foo: 'bar' });
     await object.save();
   });
+
   it('expect afterEvent create', async done => {
     await reconfigureServer({
       liveQuery: {
@@ -551,6 +557,79 @@ describe('ParseLiveQuery', function () {
     await object.save();
   });
 
+  it('can handle beforeConnect validation function', async done => {
+    await reconfigureServer({
+      liveQuery: {
+        classNames: ['TestObject'],
+      },
+      startLiveQueryServer: true,
+      verbose: false,
+      silent: true,
+    });
+
+    const object = new TestObject();
+    await object.save();
+
+    Parse.Cloud.beforeConnect(() => {}, validatorFail);
+    let complete = false;
+    Parse.LiveQuery.on('error', error => {
+      if (complete) {
+        return;
+      }
+      complete = true;
+      expect(error).toBe('you are not authorized');
+      done();
+    });
+    const query = new Parse.Query(TestObject);
+    query.equalTo('objectId', object.id);
+    await query.subscribe();
+  });
+
+  it('can handle beforeSubscribe validation function', async done => {
+    await reconfigureServer({
+      liveQuery: {
+        classNames: ['TestObject'],
+      },
+      startLiveQueryServer: true,
+      verbose: false,
+      silent: true,
+    });
+    const object = new TestObject();
+    await object.save();
+
+    Parse.Cloud.beforeSubscribe(TestObject, () => {}, validatorFail);
+    const query = new Parse.Query(TestObject);
+    query.equalTo('objectId', object.id);
+    const subscription = await query.subscribe();
+    subscription.on('error', error => {
+      expect(error).toBe('you are not authorized');
+      done();
+    });
+  });
+
+  it('can handle afterEvent validation function', async done => {
+    await reconfigureServer({
+      liveQuery: {
+        classNames: ['TestObject'],
+      },
+      startLiveQueryServer: true,
+      verbose: false,
+      silent: true,
+    });
+    Parse.Cloud.afterLiveQueryEvent('TestObject', () => {}, validatorFail);
+
+    const query = new Parse.Query(TestObject);
+    const subscription = await query.subscribe();
+    subscription.on('error', error => {
+      expect(error).toBe('you are not authorized');
+      done();
+    });
+
+    const object = new TestObject();
+    object.set('foo', 'bar');
+    await object.save();
+  });
+
   it('can handle beforeConnect error', async done => {
     await reconfigureServer({
       liveQuery: {