chore(package): update jasmine to version 3.0.0 (#4553)

* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect
This commit is contained in:
Florent Vilmart
2018-02-17 09:55:30 -05:00
committed by GitHub
parent 8ec7785d53
commit b754d51e8e
81 changed files with 2698 additions and 2704 deletions

View File

@@ -1,16 +1,16 @@
var PushRouter = require('../src/Routers/PushRouter').PushRouter;
var request = require('request');
const PushRouter = require('../src/Routers/PushRouter').PushRouter;
const request = require('request');
describe('PushRouter', () => {
it('can get query condition when channels is set', (done) => {
// Make mock request
var request = {
const request = {
body: {
channels: ['Giants', 'Mets']
}
}
var where = PushRouter.getQueryCondition(request);
const where = PushRouter.getQueryCondition(request);
expect(where).toEqual({
'channels': {
'$in': ['Giants', 'Mets']
@@ -21,7 +21,7 @@ describe('PushRouter', () => {
it('can get query condition when where is set', (done) => {
// Make mock request
var request = {
const request = {
body: {
'where': {
'injuryReports': true
@@ -29,7 +29,7 @@ describe('PushRouter', () => {
}
}
var where = PushRouter.getQueryCondition(request);
const where = PushRouter.getQueryCondition(request);
expect(where).toEqual({
'injuryReports': true
});
@@ -38,7 +38,7 @@ describe('PushRouter', () => {
it('can get query condition when nothing is set', (done) => {
// Make mock request
var request = {
const request = {
body: {
}
}
@@ -51,7 +51,7 @@ describe('PushRouter', () => {
it('can throw on getQueryCondition when channels and where are set', (done) => {
// Make mock request
var request = {
const request = {
body: {
'channels': {
'$in': ['Giants', 'Mets']