chore(package): update jasmine to version 3.0.0 (#4553)

* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect
This commit is contained in:
Florent Vilmart
2018-02-17 09:55:30 -05:00
committed by GitHub
parent 8ec7785d53
commit b754d51e8e
81 changed files with 2698 additions and 2704 deletions

View File

@@ -1,12 +1,12 @@
// This is a port of the test suite:
// hungry/js/test/parse_acl_test.js
var rest = require('../src/rest');
var Config = require('../src/Config');
var auth = require('../src/Auth');
const rest = require('../src/rest');
const Config = require('../src/Config');
const auth = require('../src/Auth');
describe('Parse.ACL', () => {
it("acl must be valid", (done) => {
var user = new Parse.User();
const user = new Parse.User();
ok(!user.setACL("Ceci n'est pas un ACL.", {
error: function(user, error) {
equal(error.code, -1);
@@ -17,13 +17,13 @@ describe('Parse.ACL', () => {
it("refresh object with acl", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -41,13 +41,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and public get", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -60,7 +60,7 @@ describe('Parse.ACL', () => {
Parse.User.logOut()
.then(() => {
// Get
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.get(object.id, {
success: function() {
fail('Should not have retrieved the object.');
@@ -80,13 +80,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and public find", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -100,7 +100,7 @@ describe('Parse.ACL', () => {
Parse.User.logOut()
.then(() => {
// Find
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.find({
success: function(results) {
equal(results.length, 0);
@@ -117,13 +117,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and public update", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -156,13 +156,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and public delete", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -190,13 +190,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and logged in get", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -211,7 +211,7 @@ describe('Parse.ACL', () => {
Parse.User.logIn("alice", "wonderland", {
success: function() {
// Get
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.get(object.id, {
success: function(result) {
ok(result);
@@ -235,13 +235,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and logged in find", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -256,11 +256,11 @@ describe('Parse.ACL', () => {
Parse.User.logIn("alice", "wonderland", {
success: function() {
// Find
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.find({
success: function(results) {
equal(results.length, 1);
var result = results[0];
const result = results[0];
ok(result);
if (!result) {
return fail();
@@ -285,13 +285,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and logged in update", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -323,13 +323,13 @@ describe('Parse.ACL', () => {
it("acl an object owned by one user and logged in delete", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -360,13 +360,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly readable and public get", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -389,7 +389,7 @@ describe('Parse.ACL', () => {
Parse.User.logOut()
.then(() => {
// Get
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.get(object.id, {
success: function(result) {
ok(result);
@@ -408,13 +408,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly readable and public find", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -437,11 +437,11 @@ describe('Parse.ACL', () => {
Parse.User.logOut()
.then(() => {
// Find
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.find({
success: function(results) {
equal(results.length, 1);
var result = results[0];
const result = results[0];
ok(result);
equal(result.id, object.id);
done();
@@ -458,13 +458,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly readable and public update", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -505,13 +505,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly readable and public delete", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -549,13 +549,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly writable and public get", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -578,7 +578,7 @@ describe('Parse.ACL', () => {
Parse.User.logOut()
.then(() => {
// Get
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.get(object.id, {
error: function(model, error) {
equal(error.code, Parse.Error.OBJECT_NOT_FOUND);
@@ -596,13 +596,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly writable and public find", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -625,7 +625,7 @@ describe('Parse.ACL', () => {
Parse.User.logOut()
.then(() => {
// Find
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.find({
success: function(results) {
equal(results.length, 0);
@@ -643,13 +643,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly writable and public update", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -689,13 +689,13 @@ describe('Parse.ACL', () => {
it("acl making an object publicly writable and public delete", (done) => {
// Create an object owned by Alice.
var user = new Parse.User();
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp(null, {
success: function() {
var object = new TestObject();
var acl = new Parse.ACL(user);
const object = new TestObject();
const acl = new Parse.ACL(user);
object.setACL(acl);
object.save(null, {
success: function() {
@@ -734,14 +734,14 @@ describe('Parse.ACL', () => {
it("acl making an object privately writable (#3194)", (done) => {
// Create an object owned by Alice.
var object;
var user2;
var user = new Parse.User();
let object;
let user2;
const user = new Parse.User();
user.set("username", "alice");
user.set("password", "wonderland");
user.signUp().then(() => {
object = new TestObject();
var acl = new Parse.ACL(user);
const acl = new Parse.ACL(user);
acl.setPublicWriteAccess(false);
acl.setPublicReadAccess(true);
object.setACL(acl);
@@ -774,8 +774,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -791,7 +791,7 @@ describe('Parse.ACL', () => {
// Sign in as Bob again.
Parse.User.logIn("bob", "pass", {
success: function() {
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.get(object.id, {
success: function(result) {
ok(result);
@@ -820,8 +820,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -837,11 +837,11 @@ describe('Parse.ACL', () => {
// Sign in as Bob again.
Parse.User.logIn("bob", "pass", {
success: function() {
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.find({
success: function(results) {
equal(results.length, 1);
var result = results[0];
const result = results[0];
ok(result);
if (!result) {
fail("should have result");
@@ -872,8 +872,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -916,8 +916,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -960,8 +960,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -977,7 +977,7 @@ describe('Parse.ACL', () => {
// Start making requests by the public.
Parse.User.logOut()
.then(() => {
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.get(object.id).then((result) => {
fail(result);
}, (error) => {
@@ -1004,8 +1004,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -1021,7 +1021,7 @@ describe('Parse.ACL', () => {
// Start making requests by the public.
Parse.User.logOut()
.then(() => {
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.find({
success: function(results) {
equal(results.length, 0);
@@ -1048,8 +1048,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -1092,8 +1092,8 @@ describe('Parse.ACL', () => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
// Create an object shared by Bob and Alice.
var object = new TestObject();
var acl = new Parse.ACL(alice);
const object = new TestObject();
const acl = new Parse.ACL(alice);
acl.setWriteAccess(bob, true);
acl.setReadAccess(bob, true);
object.setACL(acl);
@@ -1127,10 +1127,10 @@ describe('Parse.ACL', () => {
it("acl saveAll with permissions", (done) => {
Parse.User.signUp("alice", "wonderland", null, {
success: function(alice) {
var acl = new Parse.ACL(alice);
const acl = new Parse.ACL(alice);
var object1 = new TestObject();
var object2 = new TestObject();
const object1 = new TestObject();
const object2 = new TestObject();
object1.setACL(acl);
object2.setACL(acl);
Parse.Object.saveAll([object1, object2], {
@@ -1149,7 +1149,7 @@ describe('Parse.ACL', () => {
object2.set("foo", "bar");
Parse.Object.saveAll([object1, object2], {
success: function() {
var query = new Parse.Query(TestObject);
const query = new Parse.Query(TestObject);
query.equalTo("foo", "bar");
query.find({
success: function(results) {
@@ -1193,16 +1193,16 @@ describe('Parse.ACL', () => {
});
it("query for included object with ACL works", (done) => {
var obj1 = new Parse.Object("TestClass1");
var obj2 = new Parse.Object("TestClass2");
var acl = new Parse.ACL();
const obj1 = new Parse.Object("TestClass1");
const obj2 = new Parse.Object("TestClass2");
const acl = new Parse.ACL();
acl.setPublicReadAccess(true);
obj2.set("ACL", acl);
obj1.set("other", obj2);
obj1.save(null, expectSuccess({
success: function() {
obj2._clearServerData();
var query = new Parse.Query("TestClass1");
const query = new Parse.Query("TestClass1");
query.first(expectSuccess({
success: function(obj1Again) {
ok(!obj1Again.get("other").get("ACL"));
@@ -1221,11 +1221,11 @@ describe('Parse.ACL', () => {
});
it('restricted ACL does not have public access', (done) => {
var obj = new Parse.Object("TestClassMasterACL");
var acl = new Parse.ACL();
const obj = new Parse.Object("TestClassMasterACL");
const acl = new Parse.ACL();
obj.set('ACL', acl);
obj.save().then(() => {
var query = new Parse.Query("TestClassMasterACL");
const query = new Parse.Query("TestClassMasterACL");
return query.find();
}).then((results) => {
ok(!results.length, 'Should not have returned object with secure ACL.');
@@ -1235,7 +1235,7 @@ describe('Parse.ACL', () => {
it('regression test #701', done => {
const config = Config.get('test');
var anonUser = {
const anonUser = {
authData: {
anonymous: {
id: '00000000-0000-0000-0000-000000000001'
@@ -1245,8 +1245,8 @@ describe('Parse.ACL', () => {
Parse.Cloud.afterSave(Parse.User, req => {
if (!req.object.existed()) {
var user = req.object;
var acl = new Parse.ACL(user);
const user = req.object;
const acl = new Parse.ACL(user);
user.setACL(acl);
user.save(null, {useMasterKey: true}).then(user => {
new Parse.Query('_User').get(user.objectId).then(() => {