joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(package): update jasmine to version 3.0.0 (#4553)

Browse Source 
* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect
This commit is contained in:
Florent Vilmart
2018-02-17 09:55:30 -05:00
committed by GitHub
parent 8ec7785d53
commit b754d51e8e
81 changed files with 2698 additions and 2704 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/LoggerController.spec.js
View File

@@ -1,12 +1,12 @@
var LoggerController = require('../src/Controllers/LoggerController').LoggerController;
var WinstonLoggerAdapter = require('../src/Adapters/Logger/WinstonLoggerAdapter').WinstonLoggerAdapter;
const LoggerController = require('../src/Controllers/LoggerController').LoggerController;
const WinstonLoggerAdapter = require('../src/Adapters/Logger/WinstonLoggerAdapter').WinstonLoggerAdapter;
describe('LoggerController', () => {
it('can check process a query without throwing', (done) => {
// Make mock request
var query = {};
const query = {};
var loggerController = new LoggerController(new WinstonLoggerAdapter());
const loggerController = new LoggerController(new WinstonLoggerAdapter());
expect(() => {
loggerController.getLogs(query).then(function(res) {
@@ -29,7 +29,7 @@ describe('LoggerController', () => {
it('can set the proper default values', (done) => {
// Make mock request
var result = LoggerController.parseOptions();
const result = LoggerController.parseOptions();
expect(result.size).toEqual(10);
expect(result.order).toEqual('desc');
expect(result.level).toEqual('info');
@@ -39,7 +39,7 @@ describe('LoggerController', () => {
it('can process a query without throwing', (done) => {
// Make mock request
var query = {
const query = {
from: "2016-01-01Z00:00:00",
until: "2016-01-01Z00:00:00",
size: 5,
@@ -47,7 +47,7 @@ describe('LoggerController', () => {
level: 'error'
};
var result = LoggerController.parseOptions(query);
const result = LoggerController.parseOptions(query);
expect(result.from.getTime()).toEqual(1451606400000);
expect(result.until.getTime()).toEqual(1451606400000);
@@ -60,7 +60,7 @@ describe('LoggerController', () => {
it('can check process a query without throwing', (done) => {
// Make mock request
var query = {
const query = {
from: "2016-01-01",
until: "2016-01-30",
size: 5,
@@ -68,7 +68,7 @@ describe('LoggerController', () => {
level: 'error'
};
var loggerController = new LoggerController(new WinstonLoggerAdapter());
const loggerController = new LoggerController(new WinstonLoggerAdapter());
expect(() => {
loggerController.getLogs(query).then(function(res) {