chore(package): update jasmine to version 3.0.0 (#4553)

* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect

spec/InstallationsRouter.spec.js

@@ -1,20 +1,20 @@
-var auth = require('../src/Auth');
-var Config = require('../src/Config');
-var rest = require('../src/rest');
-var InstallationsRouter = require('../src/Routers/InstallationsRouter').InstallationsRouter;
+const auth = require('../src/Auth');
+const Config = require('../src/Config');
+const rest = require('../src/rest');
+const InstallationsRouter = require('../src/Routers/InstallationsRouter').InstallationsRouter;
 
 describe('InstallationsRouter', () => {
   it('uses find condition from request.body', (done) => {
-    var config = Config.get('test');
-    var androidDeviceRequest = {
+    const config = Config.get('test');
+    const androidDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abc',
       'deviceType': 'android'
     };
-    var iosDeviceRequest = {
+    const iosDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abd',
       'deviceType': 'ios'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {
@@ -26,14 +26,14 @@ describe('InstallationsRouter', () => {
       info: {}
     };
 
-    var router = new InstallationsRouter();
+    const router = new InstallationsRouter();
     rest.create(config, auth.nobody(config), '_Installation', androidDeviceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Installation', iosDeviceRequest);
       }).then(() => {
         return router.handleFind(request);
       }).then((res) => {
-        var results = res.response.results;
+        const results = res.response.results;
         expect(results.length).toEqual(1);
         done();
       }).catch((err) => {
@@ -43,16 +43,16 @@ describe('InstallationsRouter', () => {
   });
 
   it('uses find condition from request.query', (done) => {
-    var config = Config.get('test');
-    var androidDeviceRequest = {
+    const config = Config.get('test');
+    const androidDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abc',
       'deviceType': 'android'
     };
-    var iosDeviceRequest = {
+    const iosDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abd',
       'deviceType': 'ios'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -64,14 +64,14 @@ describe('InstallationsRouter', () => {
       info: {}
     };
 
-    var router = new InstallationsRouter();
+    const router = new InstallationsRouter();
     rest.create(config, auth.nobody(config), '_Installation', androidDeviceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Installation', iosDeviceRequest);
       }).then(() => {
         return router.handleFind(request);
       }).then((res) => {
-        var results = res.response.results;
+        const results = res.response.results;
         expect(results.length).toEqual(1);
         done();
       }).catch((err) => {
@@ -81,16 +81,16 @@ describe('InstallationsRouter', () => {
   });
 
   it('query installations with limit = 0', (done) => {
-    var config = Config.get('test');
-    var androidDeviceRequest = {
+    const config = Config.get('test');
+    const androidDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abc',
       'deviceType': 'android'
     };
-    var iosDeviceRequest = {
+    const iosDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abd',
       'deviceType': 'ios'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -101,14 +101,14 @@ describe('InstallationsRouter', () => {
     };
 
     Config.get('test');
-    var router = new InstallationsRouter();
+    const router = new InstallationsRouter();
     rest.create(config, auth.nobody(config), '_Installation', androidDeviceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Installation', iosDeviceRequest);
       }).then(() => {
         return router.handleFind(request);
       }).then((res) => {
-        var response = res.response;
+        const response = res.response;
         expect(response.results.length).toEqual(0);
         done();
       }).catch((err) => {
@@ -118,16 +118,16 @@ describe('InstallationsRouter', () => {
   });
 
   it('query installations with count = 1', done => {
-    var config = Config.get('test');
-    var androidDeviceRequest = {
+    const config = Config.get('test');
+    const androidDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abc',
       'deviceType': 'android'
     };
-    var iosDeviceRequest = {
+    const iosDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abd',
       'deviceType': 'ios'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -137,12 +137,12 @@ describe('InstallationsRouter', () => {
       info: {}
     };
 
-    var router = new InstallationsRouter();
+    const router = new InstallationsRouter();
     rest.create(config, auth.nobody(config), '_Installation', androidDeviceRequest)
       .then(() => rest.create(config, auth.nobody(config), '_Installation', iosDeviceRequest))
       .then(() => router.handleFind(request))
       .then((res) => {
-        var response = res.response;
+        const response = res.response;
         expect(response.results.length).toEqual(2);
         expect(response.count).toEqual(2);
         done();
@@ -154,16 +154,16 @@ describe('InstallationsRouter', () => {
   });
 
   it('query installations with limit = 0 and count = 1', (done) => {
-    var config = Config.get('test');
-    var androidDeviceRequest = {
+    const config = Config.get('test');
+    const androidDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abc',
       'deviceType': 'android'
     };
-    var iosDeviceRequest = {
+    const iosDeviceRequest = {
       'installationId': '12345678-abcd-abcd-abcd-123456789abd',
       'deviceType': 'ios'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -174,14 +174,14 @@ describe('InstallationsRouter', () => {
       info: {}
     };
 
-    var router = new InstallationsRouter();
+    const router = new InstallationsRouter();
     rest.create(config, auth.nobody(config), '_Installation', androidDeviceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Installation', iosDeviceRequest);
       }).then(() => {
         return router.handleFind(request);
       }).then((res) => {
-        var response = res.response;
+        const response = res.response;
         expect(response.results.length).toEqual(0);
         expect(response.count).toEqual(2);
         done();