chore(package): update jasmine to version 3.0.0 (#4553)

* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect
This commit is contained in:
Florent Vilmart
2018-02-17 09:55:30 -05:00
committed by GitHub
parent 8ec7785d53
commit b754d51e8e
81 changed files with 2698 additions and 2704 deletions

View File

@@ -1,14 +1,14 @@
'use strict';
var httpRequest = require("../src/cloud-code/httpRequest"),
const httpRequest = require("../src/cloud-code/httpRequest"),
HTTPResponse = require('../src/cloud-code/HTTPResponse').default,
bodyParser = require('body-parser'),
express = require("express");
var port = 13371;
var httpRequestServer = "http://localhost:" + port;
const port = 13371;
const httpRequestServer = "http://localhost:" + port;
var app = express();
const app = express();
app.use(bodyParser.json({ 'type': '*/*' }));
app.get("/hello", function(req, res){
res.json({response: "OK"});
@@ -53,7 +53,7 @@ describe("httpRequest", () => {
});
it("should do /hello with callback and promises", (done) => {
var calls = 0;
let calls = 0;
httpRequest({
url: httpRequestServer + "/hello",
success: function() { calls++; },
@@ -102,7 +102,7 @@ describe("httpRequest", () => {
});
it("should fail on 404", (done) => {
var calls = 0;
let calls = 0;
httpRequest({
url: httpRequestServer + "/404",
success: function() {
@@ -138,7 +138,7 @@ describe("httpRequest", () => {
})
it("should post on echo", (done) => {
var calls = 0;
let calls = 0;
httpRequest({
method: "POST",
url: httpRequestServer + "/echo",
@@ -307,7 +307,7 @@ describe("httpRequest", () => {
const httpResponse = new HTTPResponse({}, new Buffer(json));
const encoded = Parse._encode(httpResponse);
let foundData, foundText, foundBody = false;
for(var key in encoded) {
for(const key in encoded) {
if (key == 'data') {
foundData = true;
}