chore(package): update jasmine to version 3.0.0 (#4553)

* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect

spec/AudienceRouter.spec.js

@@ -1,20 +1,20 @@
-var auth = require('../src/Auth');
-var Config = require('../src/Config');
-var rest = require('../src/rest');
-var AudiencesRouter = require('../src/Routers/AudiencesRouter').AudiencesRouter;
+const auth = require('../src/Auth');
+const Config = require('../src/Config');
+const rest = require('../src/rest');
+const AudiencesRouter = require('../src/Routers/AudiencesRouter').AudiencesRouter;
 
 describe('AudiencesRouter', () => {
   it('uses find condition from request.body', (done) => {
-    var config = Config.get('test');
-    var androidAudienceRequest = {
+    const config = Config.get('test');
+    const androidAudienceRequest = {
       'name': 'Android Users',
       'query': '{ "test": "android" }'
     };
-    var iosAudienceRequest = {
+    const iosAudienceRequest = {
       'name': 'Iphone Users',
       'query': '{ "test": "ios" }'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {
@@ -26,7 +26,7 @@ describe('AudiencesRouter', () => {
       info: {}
     };
 
-    var router = new AudiencesRouter();
+    const router = new AudiencesRouter();
     rest.create(config, auth.nobody(config), '_Audience', androidAudienceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Audience', iosAudienceRequest);
@@ -35,7 +35,7 @@ describe('AudiencesRouter', () => {
         return router.handleFind(request);
       })
       .then((res) => {
-        var results = res.response.results;
+        const results = res.response.results;
         expect(results.length).toEqual(1);
         done();
       })
@@ -46,16 +46,16 @@ describe('AudiencesRouter', () => {
   });
 
   it('uses find condition from request.query', (done) => {
-    var config = Config.get('test');
-    var androidAudienceRequest = {
+    const config = Config.get('test');
+    const androidAudienceRequest = {
       'name': 'Android Users',
       'query': '{ "test": "android" }'
     };
-    var iosAudienceRequest = {
+    const iosAudienceRequest = {
       'name': 'Iphone Users',
       'query': '{ "test": "ios" }'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -67,7 +67,7 @@ describe('AudiencesRouter', () => {
       info: {}
     };
 
-    var router = new AudiencesRouter();
+    const router = new AudiencesRouter();
     rest.create(config, auth.nobody(config), '_Audience', androidAudienceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Audience', iosAudienceRequest);
@@ -76,7 +76,7 @@ describe('AudiencesRouter', () => {
         return router.handleFind(request);
       })
       .then((res) => {
-        var results = res.response.results;
+        const results = res.response.results;
         expect(results.length).toEqual(1);
         done();
       })
@@ -87,16 +87,16 @@ describe('AudiencesRouter', () => {
   });
 
   it('query installations with limit = 0', (done) => {
-    var config = Config.get('test');
-    var androidAudienceRequest = {
+    const config = Config.get('test');
+    const androidAudienceRequest = {
       'name': 'Android Users',
       'query': '{ "test": "android" }'
     };
-    var iosAudienceRequest = {
+    const iosAudienceRequest = {
       'name': 'Iphone Users',
       'query': '{ "test": "ios" }'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -107,7 +107,7 @@ describe('AudiencesRouter', () => {
     };
 
     Config.get('test');
-    var router = new AudiencesRouter();
+    const router = new AudiencesRouter();
     rest.create(config, auth.nobody(config), '_Audience', androidAudienceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Audience', iosAudienceRequest);
@@ -116,7 +116,7 @@ describe('AudiencesRouter', () => {
         return router.handleFind(request);
       })
       .then((res) => {
-        var response = res.response;
+        const response = res.response;
         expect(response.results.length).toEqual(0);
         done();
       })
@@ -127,16 +127,16 @@ describe('AudiencesRouter', () => {
   });
 
   it('query installations with count = 1', done => {
-    var config = Config.get('test');
-    var androidAudienceRequest = {
+    const config = Config.get('test');
+    const androidAudienceRequest = {
       'name': 'Android Users',
       'query': '{ "test": "android" }'
     };
-    var iosAudienceRequest = {
+    const iosAudienceRequest = {
       'name': 'Iphone Users',
       'query': '{ "test": "ios" }'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -146,12 +146,12 @@ describe('AudiencesRouter', () => {
       info: {}
     };
 
-    var router = new AudiencesRouter();
+    const router = new AudiencesRouter();
     rest.create(config, auth.nobody(config), '_Audience', androidAudienceRequest)
       .then(() => rest.create(config, auth.nobody(config), '_Audience', iosAudienceRequest))
       .then(() => router.handleFind(request))
       .then((res) => {
-        var response = res.response;
+        const response = res.response;
         expect(response.results.length).toEqual(2);
         expect(response.count).toEqual(2);
         done();
@@ -163,16 +163,16 @@ describe('AudiencesRouter', () => {
   });
 
   it('query installations with limit = 0 and count = 1', (done) => {
-    var config = Config.get('test');
-    var androidAudienceRequest = {
+    const config = Config.get('test');
+    const androidAudienceRequest = {
       'name': 'Android Users',
       'query': '{ "test": "android" }'
     };
-    var iosAudienceRequest = {
+    const iosAudienceRequest = {
       'name': 'Iphone Users',
       'query': '{ "test": "ios" }'
     };
-    var request = {
+    const request = {
       config: config,
       auth: auth.master(config),
       body: {},
@@ -183,7 +183,7 @@ describe('AudiencesRouter', () => {
       info: {}
     };
 
-    var router = new AudiencesRouter();
+    const router = new AudiencesRouter();
     rest.create(config, auth.nobody(config), '_Audience', androidAudienceRequest)
       .then(() => {
         return rest.create(config, auth.nobody(config), '_Audience', iosAudienceRequest);
@@ -192,7 +192,7 @@ describe('AudiencesRouter', () => {
         return router.handleFind(request);
       })
       .then((res) => {
-        var response = res.response;
+        const response = res.response;
         expect(response.results.length).toEqual(0);
         expect(response.count).toEqual(2);
         done();