More tests

This commit is contained in:
Drew Gross
2016-02-05 12:48:36 -08:00
parent e6feefd223
commit b741539e25
2 changed files with 58 additions and 14 deletions

View File

@@ -100,9 +100,6 @@ function fieldNameIsValidForClass(fieldName, className) {
}
function invalidClassNameMessage(className) {
if (!className) {
className = '';
}
return 'Invalid classname: ' + className + ', classnames can only have alphanumeric characters and _, and must start with an alpha character ';
}
@@ -137,7 +134,7 @@ function schemaAPITypeToMongoFieldType(type) {
return { error: "invalid JSON", code: Parse.Error.INVALID_JSON };
}
switch (type.type) {
default: return { error: 'invalid field type: ' + type.type };
default: return { error: 'invalid field type: ' + type.type, code: Parse.Error.INCORRECT_TYPE };
case 'Number': return { result: 'number' };
case 'String': return { result: 'string' };
case 'Boolean': return { result: 'boolean' };
@@ -211,10 +208,10 @@ Schema.prototype.reload = function() {
// enabled) before calling this function.
Schema.prototype.addClassIfNotExists = function(className, fields) {
if (this.data[className]) {
return Promise.reject(new Parse.Error(
Parse.Error.DUPLICATE_VALUE,
'class ' + className + ' already exists'
));
return Promise.reject({
code: Parse.Error.INVALID_CLASS_NAME,
error: 'class ' + className + ' already exists',
});
}
if (!classNameIsValid(className)) {
@@ -222,9 +219,6 @@ Schema.prototype.addClassIfNotExists = function(className, fields) {
code: Parse.Error.INVALID_CLASS_NAME,
error: invalidClassNameMessage(className),
});
return Promise.reject({
code: Parse.Error.INVALID_CLASS_NAME,
});
}
for (fieldName in fields) {
if (!fieldNameIsValid(fieldName)) {