Fix apple signin authAdapter (#5891)

* Fix apple signin authAdapter to use the user id instead of the user token

* Update spec
This commit is contained in:
SebC
2019-08-08 01:08:14 +02:00
committed by Diamond Lewis
parent 0e9462bfb5
commit b246bad5c7
2 changed files with 15 additions and 6 deletions

View File

@@ -29,7 +29,7 @@ const getApplePublicKey = async () => {
return currentKey;
};
const verifyIdToken = async (token, clientID) => {
const verifyIdToken = async ({ token, id }, clientID) => {
if (!token) {
throw new Parse.Error(
Parse.Error.OBJECT_NOT_FOUND,
@@ -45,6 +45,12 @@ const verifyIdToken = async (token, clientID) => {
`id token not issued by correct OpenID provider - expected: ${TOKEN_ISSUER} | from: ${jwtClaims.iss}`
);
}
if (jwtClaims.sub !== id) {
throw new Parse.Error(
Parse.Error.OBJECT_NOT_FOUND,
`auth data is invalid for this user.`
);
}
if (clientID !== undefined && jwtClaims.aud !== clientID) {
throw new Parse.Error(
Parse.Error.OBJECT_NOT_FOUND,
@@ -56,7 +62,7 @@ const verifyIdToken = async (token, clientID) => {
// Returns a promise that fulfills if this id token is valid
function validateAuthData(authData, options = {}) {
return verifyIdToken(authData.id, options.client_id);
return verifyIdToken(authData, options.client_id);
}
// Returns a promise that fulfills if this app id is valid.