Fix apple signin authAdapter (#5891)

* Fix apple signin authAdapter to use the user id instead of the user token

* Update spec
This commit is contained in:
SebC
2019-08-08 01:08:14 +02:00
committed by Diamond Lewis
parent 0e9462bfb5
commit b246bad5c7
2 changed files with 15 additions and 6 deletions

View File

@@ -1104,7 +1104,7 @@ describe('apple signin auth adapter', () => {
it('should not verify invalid id_token', async () => {
try {
await apple.validateAuthData(
{ id: 'the_token' },
{ id: 'the_user_id', token: 'the_token' },
{ client_id: 'secret' }
);
fail();
@@ -1118,11 +1118,12 @@ describe('apple signin auth adapter', () => {
iss: 'https://appleid.apple.com',
aud: 'secret',
exp: Date.now(),
sub: 'the_user_id',
};
spyOn(jwt, 'verify').and.callFake(() => fakeClaim);
const result = await apple.validateAuthData(
{ id: 'the_token' },
{ id: 'the_user_id', token: 'the_token' },
{ client_id: 'secret' }
);
expect(result).toEqual(fakeClaim);
@@ -1131,12 +1132,13 @@ describe('apple signin auth adapter', () => {
it('should throw error with with invalid jwt issuer', async () => {
const fakeClaim = {
iss: 'https://not.apple.com',
sub: 'the_user_id',
};
spyOn(jwt, 'verify').and.callFake(() => fakeClaim);
try {
await apple.validateAuthData(
{ id: 'the_token' },
{ id: 'the_user_id', token: 'the_token' },
{ client_id: 'secret' }
);
fail();
@@ -1151,12 +1153,13 @@ describe('apple signin auth adapter', () => {
const fakeClaim = {
iss: 'https://appleid.apple.com',
aud: 'invalid_client_id',
sub: 'the_user_id',
};
spyOn(jwt, 'verify').and.callFake(() => fakeClaim);
try {
await apple.validateAuthData(
{ id: 'the_token' },
{ id: 'the_user_id', token: 'the_token' },
{ client_id: 'secret' }
);
fail();