joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for authenticating with instagram (#7173)

Browse Source 
* Fix for authenticating with instagram

* Change tests for instagram authentication

* Instagram authentication for the case when data child object is presented in the response
This commit is contained in:
OverDrive
2021-02-19 20:19:13 +01:00
committed by GitHub
parent c05102b90c
commit a1cd631425
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/AuthenticationAdapters.spec.js
View File

@@ -5,7 +5,7 @@ const authenticationLoader = require('../lib/Adapters/Auth');
const path = require('path'); const path = require('path');
const responses = { const responses = {
gpgames: { playerId: 'userId' }, gpgames: { playerId: 'userId' },
instagram: { data: { id: 'userId' } }, instagram: { id: 'userId' },
janrainengage: { stat: 'ok', profile: { identifier: 'userId' } }, janrainengage: { stat: 'ok', profile: { identifier: 'userId' } },
janraincapture: { stat: 'ok', result: 'userId' }, janraincapture: { stat: 'ok', result: 'userId' },
line: { userId: 'userId' }, line: { userId: 'userId' },
@@ -492,7 +492,15 @@ describe('instagram auth adapter', () => {
'https://graph.instagram.com/me?fields=id&access_token=the_token' 'https://graph.instagram.com/me?fields=id&access_token=the_token'
); );
}); });
it('response object without data child', async () => {
spyOn(httpsRequest, 'get').and.callFake(() => {
return Promise.resolve({ id: 'userId' });
});
await instagram.validateAuthData({ id: 'userId', access_token: 'the_token' }, {});
expect(httpsRequest.get).toHaveBeenCalledWith(
'https://graph.instagram.com/me?fields=id&access_token=the_token'
);
});
it('should pass in api url', async () => { it('should pass in api url', async () => {
spyOn(httpsRequest, 'get').and.callFake(() => { spyOn(httpsRequest, 'get').and.callFake(() => {
return Promise.resolve({ data: { id: 'userId' } }); return Promise.resolve({ data: { id: 'userId' } });

3
src/Adapters/Auth/instagram.js
View File

@@ -8,7 +8,8 @@ function validateAuthData(authData) {
const apiURL = authData.apiURL || defaultURL; const apiURL = authData.apiURL || defaultURL;
const path = `${apiURL}me?fields=id&access_token=${authData.access_token}`; const path = `${apiURL}me?fields=id&access_token=${authData.access_token}`;
return httpsRequest.get(path).then(response => { return httpsRequest.get(path).then(response => {
if (response && response.data && response.data.id == authData.id) { const user = response.data ? response.data : response
if (user && user.id == authData.id) {
return; return;
} }
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'Instagram auth is invalid for this user.'); throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'Instagram auth is invalid for this user.');