Refactors configuration management (#4271)

* Adds flow types / Configuration interfaces

* Lets call it options

* Use a single interface to generate the configurations

* Translates options to definitions only if comments are set

* improves logic

* Moves objects around

* Fixes issue affecting logging of circular objects

* fixes undefined env

* Moves all defaults to defaults

* Adds back CLI defaults

* Restored defaults in commander.js

* Merge provided defaults and platform defaults

* Addresses visual nits

* Improves Config.js code

* Adds ability to pass the default value in trailing comments

* Load platform defaults from the definitions file

* proper default values on various options

* Adds ParseServer.start and server.start(options) as quick startup methods

* Moves creating liveQueryServer http into ParseServer.js

* removes dead code

* Adds tests to guarantee we can start a LQ Server from main module

* Fixes incorrect code regading liveQuery init port

* Start a http server for LQ if port is specified

* ensure we dont fail if config.port is not set

* Specify port

* ignore other path skipped in tests

* Adds test for custom middleware setting

* Refactors new Config into Config.get

- Hides AppCache from ParseServer.js, use Config.put which validates

* Extracts controller creation into Controllers/index.js

- This makes the ParseServer init way simpler

* Move serverURL inference into ParseServer

* review nits

src/Config.js

@@ -18,65 +18,34 @@ function removeTrailingSlash(str) {
 }
 
 export class Config {
-  constructor(applicationId: string, mount: string) {
+  static get(applicationId: string, mount: string) {
     const cacheInfo = AppCache.get(applicationId);
     if (!cacheInfo) {
       return;
     }
+    const config = new Config();
+    config.applicationId = applicationId;
+    Object.keys(cacheInfo).forEach((key) => {
+      if (key == 'databaseController') {
+        const schemaCache = new SchemaCache(cacheInfo.cacheController,
+          cacheInfo.schemaCacheTTL,
+          cacheInfo.enableSingleSchemaCache);
+        config.database = new DatabaseController(cacheInfo.databaseController.adapter, schemaCache);
+      } else {
+        config[key] = cacheInfo[key];
+      }
+    });
+    config.mount = removeTrailingSlash(mount);
+    config.generateSessionExpiresAt = config.generateSessionExpiresAt.bind(config);
+    config.generateEmailVerifyTokenExpiresAt = config.generateEmailVerifyTokenExpiresAt.bind(config);
+    return config;
+  }
 
-    this.applicationId = applicationId;
-    this.jsonLogs = cacheInfo.jsonLogs;
-    this.masterKey = cacheInfo.masterKey;
-    this.masterKeyIps = cacheInfo.masterKeyIps;
-    this.clientKey = cacheInfo.clientKey;
-    this.javascriptKey = cacheInfo.javascriptKey;
-    this.dotNetKey = cacheInfo.dotNetKey;
-    this.restAPIKey = cacheInfo.restAPIKey;
-    this.webhookKey = cacheInfo.webhookKey;
-    this.fileKey = cacheInfo.fileKey;
-    this.allowClientClassCreation = cacheInfo.allowClientClassCreation;
-    this.userSensitiveFields = cacheInfo.userSensitiveFields;
-
-    // Create a new DatabaseController per request
-    if (cacheInfo.databaseController) {
-      const schemaCache = new SchemaCache(cacheInfo.cacheController, cacheInfo.schemaCacheTTL, cacheInfo.enableSingleSchemaCache);
-      this.database = new DatabaseController(cacheInfo.databaseController.adapter, schemaCache);
-    }
-
-    this.schemaCacheTTL = cacheInfo.schemaCacheTTL;
-    this.enableSingleSchemaCache = cacheInfo.enableSingleSchemaCache;
-
-    this.serverURL = cacheInfo.serverURL;
-    this.publicServerURL = removeTrailingSlash(cacheInfo.publicServerURL);
-    this.verifyUserEmails = cacheInfo.verifyUserEmails;
-    this.preventLoginWithUnverifiedEmail = cacheInfo.preventLoginWithUnverifiedEmail;
-    this.emailVerifyTokenValidityDuration = cacheInfo.emailVerifyTokenValidityDuration;
-    this.accountLockout = cacheInfo.accountLockout;
-    this.passwordPolicy = cacheInfo.passwordPolicy;
-    this.appName = cacheInfo.appName;
-
-    this.analyticsController = cacheInfo.analyticsController;
-    this.cacheController = cacheInfo.cacheController;
-    this.hooksController = cacheInfo.hooksController;
-    this.filesController = cacheInfo.filesController;
-    this.pushController = cacheInfo.pushController;
-    this.pushControllerQueue = cacheInfo.pushControllerQueue;
-    this.pushWorker = cacheInfo.pushWorker;
-    this.hasPushSupport = cacheInfo.hasPushSupport;
-    this.hasPushScheduledSupport = cacheInfo.hasPushScheduledSupport;
-    this.loggerController = cacheInfo.loggerController;
-    this.userController = cacheInfo.userController;
-    this.authDataManager = cacheInfo.authDataManager;
-    this.customPages = cacheInfo.customPages || {};
-    this.mount = removeTrailingSlash(mount);
-    this.liveQueryController = cacheInfo.liveQueryController;
-    this.sessionLength = cacheInfo.sessionLength;
-    this.maxLimit = cacheInfo.maxLimit;
-    this.expireInactiveSessions = cacheInfo.expireInactiveSessions;
-    this.generateSessionExpiresAt = this.generateSessionExpiresAt.bind(this);
-    this.generateEmailVerifyTokenExpiresAt = this.generateEmailVerifyTokenExpiresAt.bind(this);
-    this.revokeSessionOnPasswordReset = cacheInfo.revokeSessionOnPasswordReset;
-    this.objectIdSize = cacheInfo.objectIdSize;
+  static put(serverConfiguration) {
+    Config.validate(serverConfiguration);
+    AppCache.put(serverConfiguration.appId, serverConfiguration);
+    Config.setupPasswordValidator(serverConfiguration.passwordPolicy);
+    return serverConfiguration;
   }
 
   static validate({