Improves config loading and tests

src/cli/utils/commander.js

@@ -1,12 +1,12 @@
 import { Command } from 'commander';
-
+import path from 'path';
 let _definitions;
 let _reverseDefinitions;
 let _defaults;
 
 Command.prototype.loadDefinitions = function(definitions) {
   _definitions = definitions;
-  
+
   Object.keys(definitions).reduce((program, opt) => {
     if (typeof definitions[opt] == "object") {
       const additionalOptions = definitions[opt];
@@ -18,14 +18,14 @@ Command.prototype.loadDefinitions = function(definitions) {
     }
     return program.option(`--${opt} [${opt}]`);
   }, this);
-  
+
   _defaults = Object.keys(definitions).reduce((defs, opt) => {
     if(_definitions[opt].default) {
       defs[opt] = _definitions[opt].default;
     }
     return defs;
   }, {});
-  
+
   _reverseDefinitions = Object.keys(definitions).reduce((object, key) => {
       let value = definitions[key];
       if (typeof value == "object") {
@@ -36,7 +36,7 @@ Command.prototype.loadDefinitions = function(definitions) {
       }
       return object;
    }, {});
-   
+
    /* istanbul ignore next */
    this.on('--help', function(){
     console.log('  Configure From Environment:');
@@ -58,17 +58,46 @@ function parseEnvironment(env = {}) {
       }
       options[_reverseDefinitions[key]] = action(env[key]);
     }
-    return options; 
+    return options;
   }, {});
 }
 
+function parseConfigFile(program) {
+  let options = {};
+  if (program.args.length > 0) {
+    let jsonPath = program.args[0];
+    jsonPath = path.resolve(jsonPath);
+    let jsonConfig = require(jsonPath);
+    if (jsonConfig.apps) {
+      if (jsonConfig.apps.length > 1) {
+        throw 'Multiple apps are not supported';
+      }
+      options = jsonConfig.apps[0];
+    } else {
+      options = jsonConfig;
+    }
+    Object.keys(options).forEach((key) => {
+      let value = options[key];
+      if (!_definitions[key]) {
+        throw `error: unknown option ${key}`;
+      }
+      let action = _definitions[key].action;
+      if (action) {
+        options[key] = action(value);
+      }
+    })
+    console.log(`Configuation loaded from ${jsonPath}`)
+  }
+  return options;
+}
+
 Command.prototype.setValuesIfNeeded = function(options) {
   Object.keys(options).forEach((key) => {
    if (!this[key]) {
      this[key] = options[key];
-   } 
+   }
   });
-} 
+}
 
 Command.prototype._parse = Command.prototype.parse;
 
@@ -76,10 +105,22 @@ Command.prototype.parse = function(args, env) {
   this._parse(args);
   // Parse the environment first
   const envOptions = parseEnvironment(env);
-  
+  const fromFile = parseConfigFile(this);
   // Load the env if not passed from command line
   this.setValuesIfNeeded(envOptions);
+  // Load from file to override
+  this.setValuesIfNeeded(fromFile);
+  // Last set the defaults
   this.setValuesIfNeeded(_defaults);
 }
 
+Command.prototype.getOptions = function() {
+  return Object.keys(_definitions).reduce((options, key) => {
+    if (typeof this[key] !== 'undefined') {
+      options[key] = this[key];
+    }
+    return options;
+  }, {});
+}
+
 export default new Command();