Improves config loading and tests

spec/CLI.spec.js

@@ -1,3 +1,4 @@
+'use strict';
 var commander = require("../src/cli/utils/commander").default;
 
 var definitions = {
@@ -11,7 +12,7 @@ var definitions = {
     action: function(value) {
       var value = parseInt(value);
       if (!Number.isInteger(value)) {
-        throw "port is invalid";
+        throw "arg2 is invalid";
       }
       return value;
     }
@@ -23,7 +24,7 @@ var definitions = {
 }
 
 describe("commander additions", () => {
-  
+
   afterEach((done) => {
     commander.options = [];
     delete commander.arg0;
@@ -33,7 +34,7 @@ describe("commander additions", () => {
     delete commander.arg4;
     done();
   })
-  
+
   it("should load properly definitions from args", (done) => {
     commander.loadDefinitions(definitions);
     commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value", "--arg1", "arg1Value", "--arg2", "2", "--arg3", "some"]);
@@ -44,7 +45,7 @@ describe("commander additions", () => {
     expect(commander.arg4).toEqual("arg4Value");
     done();
   });
-  
+
   it("should load properly definitions from env", (done) => {
     commander.loadDefinitions(definitions);
     commander.parse([], {
@@ -58,7 +59,7 @@ describe("commander additions", () => {
     expect(commander.arg4).toEqual("arg4Value");
     done();
   });
-  
+
   it("should load properly use args over env", (done) => {
     commander.loadDefinitions(definitions);
     commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value", "--arg4", "anotherArg4"], {
@@ -72,7 +73,7 @@ describe("commander additions", () => {
     expect(commander.arg4).toEqual("anotherArg4");
     done();
   });
-  
+
   it("should fail in action as port is invalid", (done) => {
     commander.loadDefinitions(definitions);
     expect(()=> {
@@ -81,7 +82,58 @@ describe("commander additions", () => {
         "PROGRAM_ARG_1": "arg1ENVValue",
         "PROGRAM_ARG_2": "hello",
       });
-    }).toThrow("port is invalid");
+    }).toThrow("arg2 is invalid");
     done();
   });
-});
+
+  it("should not override config.json", (done) => {
+    commander.loadDefinitions(definitions);
+    commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value", "./spec/configs/CLIConfig.json"], {
+      "PROGRAM_ARG_0": "arg0ENVValue",
+      "PROGRAM_ARG_1": "arg1ENVValue",
+    });
+    let options = commander.getOptions();
+    expect(options.arg2).toBe(8888);
+    expect(options.arg3).toBe("hello"); //config value
+    expect(options.arg4).toBe('/1');
+    done();
+  });
+
+  it("should fail with invalid values in JSON", (done) => {
+    commander.loadDefinitions(definitions);
+    expect(() => {
+      commander.parse(["node","./CLI.spec.js","--arg0", "arg0Value", "./spec/configs/CLIConfigFail.json"], {
+        "PROGRAM_ARG_0": "arg0ENVValue",
+        "PROGRAM_ARG_1": "arg1ENVValue",
+      });
+    }).toThrow("arg2 is invalid")
+    done();
+  });
+
+  it("should fail when too many apps are set", (done) => {
+    commander.loadDefinitions(definitions);
+    expect(() => {
+      commander.parse(["node","./CLI.spec.js","./spec/configs/CLIConfigFailTooManyApps.json"]);
+    }).toThrow("Multiple apps are not supported")
+    done();
+  });
+
+  it("should load config from apps", (done) => {
+    commander.loadDefinitions(definitions);
+    commander.parse(["node", "./CLI.spec.js", "./spec/configs/CLIConfigApps.json"]);
+    let options = commander.getOptions();
+    expect(options.arg1).toBe("my_app");
+    expect(options.arg2).toBe(8888);
+    expect(options.arg3).toBe("hello"); //config value
+    expect(options.arg4).toBe('/1');
+    done();
+  });
+
+  it("should fail when passing an invalid arguement", (done) => {
+    commander.loadDefinitions(definitions);
+    expect(() => {
+      commander.parse(["node", "./CLI.spec.js", "./spec/configs/CLIConfigUnknownArg.json"]);
+    }).toThrow('error: unknown option myArg')
+    done();
+  });
+});

spec/configs/CLIConfig.json

@@ -0,0 +1,6 @@
+{
+  "arg1": "my_app",
+  "arg2": "8888",
+  "arg3": "hello",
+  "arg4": "/1"
+}

spec/configs/CLIConfigApps.json

@@ -0,0 +1,9 @@
+{
+  "apps": [
+  {
+    "arg1": "my_app",
+    "arg2": 8888,
+    "arg3": "hello",
+    "arg4": "/1"
+  }]
+}

spec/configs/CLIConfigFail.json

@@ -0,0 +1,6 @@
+{
+  "arg1": "my_app",
+  "arg2": "hello",
+  "arg3": "hello",
+  "arg4": "/1"
+}

spec/configs/CLIConfigFailTooManyApps.json

@@ -0,0 +1,16 @@
+{
+  "apps": [
+  {
+    "arg1": "my_app",
+    "arg2": "99999",
+    "arg3": "hello",
+    "arg4": "/1"
+  },
+  {
+    "arg1": "my_app2",
+    "arg2": "9999",
+    "arg3": "hello",
+    "arg4": "/1"
+  }
+  ]
+}

spec/configs/CLIConfigUnknownArg.json

@@ -0,0 +1,6 @@
+{
+  "arg1": "my_app",
+  "arg2": "8888",
+  "arg3": "hello",
+  "myArg": "/1"
+}