Adds liniting into the workflow (#3082)

* initial linting of src

* fix indent to 2 spaces

* Removes unnecessary rules

* ignore spec folder for now

* Spec linting

* Fix spec indent

* nits

* nits

* no no-empty rule

src/cli/utils/commander.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { Command } from 'commander';
 import path from 'path';
 let _definitions;
@@ -27,18 +28,18 @@ Command.prototype.loadDefinitions = function(definitions) {
   }, {});
 
   _reverseDefinitions = Object.keys(definitions).reduce((object, key) => {
-      let value = definitions[key];
-      if (typeof value == "object") {
-        value = value.env;
-      }
-      if (value) {
-        object[value] = key;
-      }
-      return object;
-   }, {});
+    let value = definitions[key];
+    if (typeof value == "object") {
+      value = value.env;
+    }
+    if (value) {
+      object[value] = key;
+    }
+    return object;
+  }, {});
 
    /* istanbul ignore next */
-   this.on('--help', function(){
+  this.on('--help', function(){
     console.log('  Configure From Environment:');
     console.log('');
     Object.keys(_reverseDefinitions).forEach((key) => {
@@ -93,9 +94,9 @@ function parseConfigFile(program) {
 
 Command.prototype.setValuesIfNeeded = function(options) {
   Object.keys(options).forEach((key) => {
-   if (!this[key]) {
-     this[key] = options[key];
-   }
+    if (!this[key]) {
+      this[key] = options[key];
+    }
   });
 }
 
@@ -124,3 +125,4 @@ Command.prototype.getOptions = function() {
 }
 
 export default new Command();
+/* eslint-enable no-console */

src/cli/utils/parsers.js

@@ -46,7 +46,7 @@ export function moduleOrObjectParser(opt) {
   }
   try {
     return JSON.parse(opt);
-  } catch(e) {}
+  } catch(e) { /* */ }
   return opt;
 }
 

src/cli/utils/runner.js

@@ -1,6 +1,5 @@
 
 import program from './commander';
-import { mergeWithOptions } from './commander';
 
 function logStartupOptions(options) {
   for (let key in options) {
@@ -11,7 +10,9 @@ function logStartupOptions(options) {
     if (typeof value === 'object') {
       value = JSON.stringify(value);
     }
+    /* eslint-disable no-console */
     console.log(`${key}: ${value}`);
+    /* eslint-enable no-console */
   }
 }