Adds liniting into the workflow (#3082)

* initial linting of src

* fix indent to 2 spaces

* Removes unnecessary rules

* ignore spec folder for now

* Spec linting

* Fix spec indent

* nits

* nits

* no no-empty rule

src/Adapters/Storage/Mongo/MongoCollection.js

@@ -84,7 +84,7 @@ export default class MongoCollection {
 
   _ensureSparseUniqueIndexInBackground(indexRequest) {
     return new Promise((resolve, reject) => {
-      this._mongoCollection.ensureIndex(indexRequest, { unique: true, background: true, sparse: true }, (error, indexName) => {
+      this._mongoCollection.ensureIndex(indexRequest, { unique: true, background: true, sparse: true }, (error) => {
         if (error) {
           reject(error);
         } else {

src/Adapters/Storage/Mongo/MongoSchemaCollection.js

@@ -1,4 +1,5 @@
 import MongoCollection from './MongoCollection';
+import Parse           from 'parse/node';
 
 function mongoFieldToParseSchemaField(type) {
   if (type[0] === '*') {
@@ -14,16 +15,16 @@ function mongoFieldToParseSchemaField(type) {
     };
   }
   switch (type) {
-    case 'number':   return {type: 'Number'};
-    case 'string':   return {type: 'String'};
-    case 'boolean':  return {type: 'Boolean'};
-    case 'date':     return {type: 'Date'};
-    case 'map':
-    case 'object':   return {type: 'Object'};
-    case 'array':    return {type: 'Array'};
-    case 'geopoint': return {type: 'GeoPoint'};
-    case 'file':     return {type: 'File'};
-    case 'bytes':    return {type: 'Bytes'};
+  case 'number':   return {type: 'Number'};
+  case 'string':   return {type: 'String'};
+  case 'boolean':  return {type: 'Boolean'};
+  case 'date':     return {type: 'Date'};
+  case 'map':
+  case 'object':   return {type: 'Object'};
+  case 'array':    return {type: 'Array'};
+  case 'geopoint': return {type: 'GeoPoint'};
+  case 'file':     return {type: 'File'};
+  case 'bytes':    return {type: 'Bytes'};
   }
 }
 
@@ -87,16 +88,16 @@ function _mongoSchemaQueryFromNameQuery(name: string, query) {
 // Does no validation. That is expected to be done in Parse Server.
 function parseFieldTypeToMongoFieldType({ type, targetClass }) {
   switch (type) {
-    case 'Pointer':  return `*${targetClass}`;
-    case 'Relation': return `relation<${targetClass}>`;
-    case 'Number':   return 'number';
-    case 'String':   return 'string';
-    case 'Boolean':  return 'boolean';
-    case 'Date':     return 'date';
-    case 'Object':   return 'object';
-    case 'Array':    return 'array';
-    case 'GeoPoint': return 'geopoint';
-    case 'File':     return 'file';
+  case 'Pointer':  return `*${targetClass}`;
+  case 'Relation': return `relation<${targetClass}>`;
+  case 'Number':   return 'number';
+  case 'String':   return 'string';
+  case 'Boolean':  return 'boolean';
+  case 'Date':     return 'date';
+  case 'Object':   return 'object';
+  case 'Array':    return 'array';
+  case 'GeoPoint': return 'geopoint';
+  case 'File':     return 'file';
   }
 }
 

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

@@ -11,7 +11,9 @@ import {
   transformWhere,
   transformUpdate,
 } from './MongoTransform';
+import Parse                 from 'parse/node';
 import _                     from 'lodash';
+import defaults              from '../../../defaults';
 
 let mongodb = require('mongodb');
 let MongoClient = mongodb.MongoClient;
@@ -63,7 +65,7 @@ const mongoSchemaFromFieldsAndClassNameAndCLP = (fields, className, classLevelPe
   }
 
   if (typeof classLevelPermissions !== 'undefined') {
-    mongoObject._metadata = mongoObject._metadata || {};
+    mongoObject._metadata = mongoObject._metadata || {};
     if (!classLevelPermissions) {
       delete mongoObject._metadata.class_permissions;
     } else {
@@ -111,14 +113,14 @@ export class MongoStorageAdapter {
         delete this.connectionPromise;
         return;
       }
-      database.on('error', (error) => {
+      database.on('error', () => {
         delete this.connectionPromise;
       });
-      database.on('close', (error) => {
+      database.on('close', () => {
         delete this.connectionPromise;
       });
       this.database = database;
-    }).catch((err) => {
+    }).catch((err) => {
       delete this.connectionPromise;
       return Promise.reject(err);
     });
@@ -288,7 +290,7 @@ export class MongoStorageAdapter {
         throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'Object not found.');
       }
       return Promise.resolve();
-    }, error => {
+    }, () => {
       throw new Parse.Error(Parse.Error.INTERNAL_SERVER_ERROR, 'Database adapter error');
     });
   }
@@ -327,7 +329,7 @@ export class MongoStorageAdapter {
     schema = convertParseSchemaToMongoSchema(schema);
     let mongoWhere = transformWhere(className, query, schema);
     let mongoSort = _.mapKeys(sort, (value, fieldName) => transformKey(className, fieldName, schema));
-    let mongoKeys = _.reduce(keys, (memo, key) => {
+    let mongoKeys = _.reduce(keys, (memo, key) => {
       memo[transformKey(className, key, schema)] = 1;
       return memo;
     }, {});

src/Adapters/Storage/Mongo/MongoTransform.js

@@ -6,10 +6,10 @@ var Parse = require('parse/node').Parse;
 const transformKey = (className, fieldName, schema) => {
   // Check if the schema is known since it's a built-in field.
   switch(fieldName) {
-    case 'objectId': return '_id';
-    case 'createdAt': return '_created_at';
-    case 'updatedAt': return '_updated_at';
-    case 'sessionToken': return '_session_token';
+  case 'objectId': return '_id';
+  case 'createdAt': return '_created_at';
+  case 'updatedAt': return '_updated_at';
+  case 'sessionToken': return '_session_token';
   }
   
   if (schema.fields[fieldName] && schema.fields[fieldName].__type == 'Pointer') {
@@ -197,7 +197,7 @@ function transformQueryKeyValue(className, key, value, schema) {
     return {key: '$or', value: value.map(subQuery => transformWhere(className, subQuery, schema))};
   case '$and':
     return {key: '$and', value: value.map(subQuery => transformWhere(className, subQuery, schema))};
-  default:
+  default: {
     // Other auth data
     const authDataMatch = key.match(/^authData\.([a-zA-Z0-9_]+)\.id$/);
     if (authDataMatch) {
@@ -206,6 +206,7 @@ function transformQueryKeyValue(className, key, value, schema) {
       return {key: `_auth_data_${provider}.id`, value};
     }
   }
+  }
 
   const expectedTypeIsArray =
     schema &&
@@ -530,8 +531,8 @@ function transformConstraint(constraint, inArray) {
       break;
 
     case '$in':
-    case '$nin':
-      var arr = constraint[key];
+    case '$nin': {
+      let arr = constraint[key];
       if (!(arr instanceof Array)) {
         throw new Parse.Error(Parse.Error.INVALID_JSON, 'bad ' + key + ' value');
       }
@@ -543,16 +544,16 @@ function transformConstraint(constraint, inArray) {
         return result;
       });
       break;
-
-    case '$all':
-      var arr = constraint[key];
+    }
+    case '$all': {
+      let arr = constraint[key];
       if (!(arr instanceof Array)) {
         throw new Parse.Error(Parse.Error.INVALID_JSON,
                               'bad ' + key + ' value');
       }
       answer[key] = arr.map(transformInteriorAtom);
       break;
-
+    }
     case '$regex':
       var s = constraint[key];
       if (typeof s !== 'string') {
@@ -736,7 +737,7 @@ const mongoObjectToParseObject = (className, mongoObject, schema) => {
   case 'symbol':
   case 'function':
     throw 'bad value in mongoObjectToParseObject';
-  case 'object':
+  case 'object': {
     if (mongoObject === null) {
       return null;
     }
@@ -868,6 +869,7 @@ const mongoObjectToParseObject = (className, mongoObject, schema) => {
     });
 
     return { ...restObject, ...relationFields };
+  }
   default:
     throw 'unknown js type';
   }