Adds liniting into the workflow (#3082)

* initial linting of src

* fix indent to 2 spaces

* Removes unnecessary rules

* ignore spec folder for now

* Spec linting

* Fix spec indent

* nits

* nits

* no no-empty rule

src/Adapters/Logger/LoggerAdapter.js

@@ -1,3 +1,4 @@
+/*eslint no-unused-vars: "off"*/
 // Logger Adapter
 //
 // Allows you to change the logger mechanism

src/Adapters/Logger/WinstonLogger.js

@@ -37,7 +37,7 @@ function updateTransports(options) {
       }, options));
   }
   // Mount the additional transports
-  additionalTransports.forEach((transport) => {
+  additionalTransports.forEach((transport) => {
     transports[transport.name] = transport;
   });
   logger.configure({
@@ -65,7 +65,7 @@ export function configureLogger({
     }
     try {
       fs.mkdirSync(logsFolder);
-    } catch (exception) {}
+    } catch (e) { /* */ }
   }
   options.dirname = logsFolder;
   options.level = logLevel;
@@ -90,7 +90,7 @@ export function removeTransport(transport) {
   logger.configure({
     transports: _.values(transports)
   });
-  _.remove(additionalTransports, (transport) => {
+  _.remove(additionalTransports, (transport) => {
     return transport.name === transportName;
   });
 }

src/Adapters/Logger/WinstonLoggerAdapter.js

@@ -3,11 +3,6 @@ import { logger, addTransport, configureLogger } from './WinstonLogger';
 
 const MILLISECONDS_IN_A_DAY = 24 * 60 * 60 * 1000;
 
-// returns Date object rounded to nearest day
-let _getNearestDay = (date) => {
-  return new Date(date.getFullYear(), date.getMonth(), date.getDate());
-}
-
 export class WinstonLoggerAdapter extends LoggerAdapter {
   constructor(options) {
     super();
@@ -38,18 +33,16 @@ export class WinstonLoggerAdapter extends LoggerAdapter {
     let limit = options.size || 10;
     let order = options.order || 'desc';
     let level = options.level || 'info';
-    let roundedUntil = _getNearestDay(until);
-    let roundedFrom = _getNearestDay(from);
 
-    var options = {
+    const queryOptions = {
       from,
       until,
       limit,
       order
     };
 
-    return new Promise((resolve, reject) => {
-      logger.query(options, (err, res) => {
+    return new Promise((resolve, reject) => {
+      logger.query(queryOptions, (err, res) => {
         if (err) {
           callback(err);
           return reject(err);