Adds liniting into the workflow (#3082)

* initial linting of src

* fix indent to 2 spaces

* Removes unnecessary rules

* ignore spec folder for now

* Spec linting

* Fix spec indent

* nits

* nits

* no no-empty rule

spec/ParseServerRESTController.spec.js

@@ -2,34 +2,34 @@ const ParseServerRESTController = require('../src/ParseServerRESTController').Pa
 const ParseServer = require('../src/ParseServer').default;
 let RESTController;
 
-describe('ParseServerRESTController', () => {
+describe('ParseServerRESTController', () => {
 
-  beforeEach(() => {
+  beforeEach(() => {
     RESTController = ParseServerRESTController(Parse.applicationId, ParseServer.promiseRouter({appId: Parse.applicationId}));
   })
 
-  it('should handle a get request', (done) => {
-    RESTController.request("GET", "/classes/MyObject").then((res) => {
+  it('should handle a get request', (done) => {
+    RESTController.request("GET", "/classes/MyObject").then((res) => {
       expect(res.results.length).toBe(0);
       done();
-    }, (err) => {
+    }, (err) => {
       console.log(err);
       jfail(err);
       done();
     });
   });
 
-  it('should handle a get request with full serverURL mount path', (done) => {
-    RESTController.request("GET", "/1/classes/MyObject").then((res) => {
+  it('should handle a get request with full serverURL mount path', (done) => {
+    RESTController.request("GET", "/1/classes/MyObject").then((res) => {
       expect(res.results.length).toBe(0);
       done();
-    }, (err) => {
+    }, (err) => {
       jfail(err);
       done();
     });
   });
 
-  it('should handle a POST batch', (done) => {
+  it('should handle a POST batch', (done) => {
     RESTController.request("POST", "batch", {
       requests: [
         {
@@ -46,72 +46,71 @@ describe('ParseServerRESTController', () => {
           path: '/classes/MyObject'
         }
       ]
-    }).then((res) => {
+    }).then((res) => {
       expect(res.length).toBe(3);
       done();
-    }, (err) => {
+    }, (err) => {
       jfail(err);
       done();
     });
   });
 
-  it('should handle a POST request', (done) => {
-    RESTController.request("POST", "/classes/MyObject", {"key": "value"}).then((res) => {
+  it('should handle a POST request', (done) => {
+    RESTController.request("POST", "/classes/MyObject", {"key": "value"}).then(() => {
       return RESTController.request("GET", "/classes/MyObject");
-    }).then((res) => {
+    }).then((res) => {
       expect(res.results.length).toBe(1);
       expect(res.results[0].key).toEqual("value");
       done();
-    }).fail((err) => {
+    }).fail((err) => {
       console.log(err);
       jfail(err);
       done();
     });
   });
 
-  it('ensures sessionTokens are properly handled', (done) => {
+  it('ensures sessionTokens are properly handled', (done) => {
     let userId;
-    Parse.User.signUp('user', 'pass').then((user) => {
+    Parse.User.signUp('user', 'pass').then((user) => {
       userId = user.id;
       let sessionToken = user.getSessionToken();
       return RESTController.request("GET", "/users/me", undefined, {sessionToken});
-    }).then((res) => {
+    }).then((res) => {
       // Result is in JSON format
       expect(res.objectId).toEqual(userId);
       done();
-    }).fail((err) => {
+    }).fail((err) => {
       console.log(err);
       jfail(err);
       done();
     });
   });
 
-  it('ensures masterKey is properly handled', (done) => {
+  it('ensures masterKey is properly handled', (done) => {
     let userId;
-    Parse.User.signUp('user', 'pass').then((user) => {
+    Parse.User.signUp('user', 'pass').then((user) => {
       userId = user.id;
-      let sessionToken = user.getSessionToken();
-      return Parse.User.logOut().then(() => {
+      return Parse.User.logOut().then(() => {
         return RESTController.request("GET", "/classes/_User", undefined, {useMasterKey: true});
       });
-    }).then((res) => {
+    }).then((res) => {
       expect(res.results.length).toBe(1);
       expect(res.results[0].objectId).toEqual(userId);
       done();
-    }, (err) => {
+    }, (err) => {
       jfail(err);
       done();
     });
   });
 
-  it('ensures no session token is created on creating users', (done) => {
-    RESTController.request("POST", "/classes/_User", {username: "hello", password: "world"}).then(() => {
+  it('ensures no session token is created on creating users', (done) => {
+    RESTController.request("POST", "/classes/_User", {username: "hello", password: "world"}).then(() => {
       let query = new Parse.Query('_Session');
       return query.find({useMasterKey: true});
-    }).then(sessions => {
+    }).then(sessions => {
       expect(sessions.length).toBe(0);
       done();
-    }, (err) => {
+    }, (err) => {
       jfail(err);
       done();
     });