joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding more information to the permission denied error (#2210)

Browse Source
This commit is contained in:
Blayne Chard
2016-07-08 03:30:29 +12:00
committed by Florent Vilmart
parent 944e5addd3
commit 8338783075
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/schemas.spec.js
View File

@@ -1054,7 +1054,7 @@ describe('schemas', () => {
fail('should not be able to add a field'); fail('should not be able to add a field');
done(); done();
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action addField on class AClass.');
done(); done();
}) })
}) })
@@ -1270,7 +1270,7 @@ describe('schemas', () => {
return query.find().then((err) => { return query.find().then((err) => {
fail('Use should hot be able to find!') fail('Use should hot be able to find!')
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action find on class AClass.');
return Promise.resolve(); return Promise.resolve();
}) })
}).then(() => { }).then(() => {
@@ -1319,7 +1319,7 @@ describe('schemas', () => {
return query.find().then((err) => { return query.find().then((err) => {
fail('User should not be able to find!') fail('User should not be able to find!')
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action find on class AClass.');
return Promise.resolve(); return Promise.resolve();
}) })
}).then(() => { }).then(() => {
@@ -1384,7 +1384,7 @@ describe('schemas', () => {
return query.find().then((err) => { return query.find().then((err) => {
fail('User should not be able to find!') fail('User should not be able to find!')
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action find on class AClass.');
return Promise.resolve(); return Promise.resolve();
}) })
}).then(() => { }).then(() => {
@@ -1442,7 +1442,7 @@ describe('schemas', () => {
return query.find().then((err) => { return query.find().then((err) => {
fail('User should not be able to find!') fail('User should not be able to find!')
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action find on class AClass.');
return Promise.resolve(); return Promise.resolve();
}) })
}).then(() => { }).then(() => {
@@ -1461,7 +1461,7 @@ describe('schemas', () => {
return query.find().then((result) => { return query.find().then((result) => {
fail('User should not be able to find!') fail('User should not be able to find!')
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action find on class AClass.');
return Promise.resolve(); return Promise.resolve();
}); });
}).then(() => { }).then(() => {
@@ -1528,7 +1528,7 @@ describe('schemas', () => {
fail("should not be able to read!"); fail("should not be able to read!");
return Promise.resolve(); return Promise.resolve();
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action create on class AClass.');
return Promise.resolve(); return Promise.resolve();
}).then(() => { }).then(() => {
return Parse.User.logIn('user2', 'user2'); return Parse.User.logIn('user2', 'user2');
@@ -1539,7 +1539,7 @@ describe('schemas', () => {
fail("should not be able to read!"); fail("should not be able to read!");
return Promise.resolve(); return Promise.resolve();
}, (err) => { }, (err) => {
expect(err.message).toEqual('Permission denied for this action.'); expect(err.message).toEqual('Permission denied for action find on class AClass.');
return Promise.resolve(); return Promise.resolve();
}).then(() => { }).then(() => {
done(); done();

4
src/Controllers/SchemaController.js
View File

@@ -683,7 +683,7 @@ class SchemaController {
// Reject create when write lockdown // Reject create when write lockdown
if (permissionField == 'writeUserFields' && operation == 'create') { if (permissionField == 'writeUserFields' && operation == 'create') {
throw new Parse.Error(Parse.Error.OPERATION_FORBIDDEN, throw new Parse.Error(Parse.Error.OPERATION_FORBIDDEN,
'Permission denied for this action.'); `Permission denied for action ${operation} on class ${className}.`);
} }
// Process the readUserFields later // Process the readUserFields later
@@ -691,7 +691,7 @@ class SchemaController {
return Promise.resolve(); return Promise.resolve();
} }
throw new Parse.Error(Parse.Error.OPERATION_FORBIDDEN, throw new Parse.Error(Parse.Error.OPERATION_FORBIDDEN,
'Permission denied for this action.'); `Permission denied for action ${operation} on class ${className}.`);
}; };
// Returns the expected type for a className+key combination // Returns the expected type for a className+key combination