joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better connection use in setClassLevelPermissions (#4460)

Browse Source 
Method `setClassLevelPermissions` should use `.task` to share the connection for the two consecutive operations. It doesn't need a transaction, because the first operation does not need to roll back when the second one fails.
This commit is contained in:
Vitaly Tomilov
2017-12-27 00:30:50 +00:00
committed by GitHub
parent a868beda93
commit 820ae2b894
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Adapters/Storage/Postgres/PostgresStorageAdapter.js
View File

@@ -605,9 +605,11 @@ export class PostgresStorageAdapter {
} }
setClassLevelPermissions(className, CLPs) { setClassLevelPermissions(className, CLPs) {
return this._ensureSchemaCollectionExists().then(() => { const self = this;
const values = [className, 'schema', 'classLevelPermissions', JSON.stringify(CLPs)] return this._client.task('set-class-level-permissions', function * (t) {
return this._client.none(`UPDATE "_SCHEMA" SET $2:name = json_object_set_key($2:name, $3::text, $4::jsonb) WHERE "className"=$1 `, values); yield self._ensureSchemaCollectionExists(t);
const values = [className, 'schema', 'classLevelPermissions', JSON.stringify(CLPs)];
yield t.none(`UPDATE "_SCHEMA" SET $2:name = json_object_set_key($2:name, $3::text, $4::jsonb) WHERE "className"=$1`, values);
}); });
} }