From 73aafa2d24aee42ab12a110374dfc438ba586ae5 Mon Sep 17 00:00:00 2001
From: Florent Vilmart <flovilmart@users.noreply.github.com>
Date: Sun, 28 May 2017 20:01:33 -0400
Subject: [PATCH] fix(tests): Stabilize flaky tests (#3876)

* Longer TTL, shorter wait

* Makes sure we wait for the logout

- Parse.User.logOut is async and was making a test flaky
---
 spec/InMemoryCache.spec.js |  4 ++--
 spec/ParseUser.spec.js     | 26 +++++++++++++-------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/spec/InMemoryCache.spec.js b/spec/InMemoryCache.spec.js
index e609236c..17c72d29 100644
--- a/spec/InMemoryCache.spec.js
+++ b/spec/InMemoryCache.spec.js
@@ -3,7 +3,7 @@ const InMemoryCache = require('../src/Adapters/Cache/InMemoryCache').default;
 
 describe('InMemoryCache', function() {
   var BASE_TTL = {
-    ttl: 10
+    ttl: 100
   };
   var NO_EXPIRE_TTL = {
     ttl: NaN
@@ -28,7 +28,7 @@ describe('InMemoryCache', function() {
     var value = cache.get(KEY);
     expect(value).toEqual(VALUE);
 
-    wait(BASE_TTL.ttl * 5).then(() => {
+    wait(BASE_TTL.ttl * 2).then(() => {
       value = cache.get(KEY)
       expect(value).toEqual(null);
       done();
diff --git a/spec/ParseUser.spec.js b/spec/ParseUser.spec.js
index 35c6413c..d8928590 100644
--- a/spec/ParseUser.spec.js
+++ b/spec/ParseUser.spec.js
@@ -1271,20 +1271,20 @@ describe('Parse.User testing', () => {
     Parse.User._registerAuthenticationProvider(provider);
     Parse.User._logInWith("facebook", {
       success: function() {
-        Parse.User.logOut();
+        Parse.User.logOut().then(() => {
+          Parse.Cloud.beforeSave(Parse.User, function(req, res) {
+            res.error("Before save shouldn't be called on login");
+          });
 
-        Parse.Cloud.beforeSave(Parse.User, function(req, res) {
-          res.error("Before save shouldn't be called on login");
-        });
-
-        Parse.User._logInWith("facebook", {
-          success: function() {
-            done();
-          },
-          error: function(model, error) {
-            ok(undefined, error);
-            done();
-          }
+          Parse.User._logInWith("facebook", {
+            success: function() {
+              done();
+            },
+            error: function(model, error) {
+              ok(undefined, error);
+              done();
+            }
+          });
         });
       }
     });