fix: adding or modifying a nested property requires addField permissions (#7679)

This commit is contained in:
Ben Devore
2021-12-06 18:52:59 -05:00
committed by GitHub
parent e7c7f44265
commit 6a6248b6cb
2 changed files with 29 additions and 1 deletions

View File

@@ -1779,6 +1779,34 @@ describe('schemas', () => {
}); });
}); });
describe('Nested documents', () => {
beforeAll(async () => {
const testSchema = new Parse.Schema('test_7371');
testSchema.setCLP({
create: { ['*']: true },
update: { ['*']: true },
addField: {},
});
testSchema.addObject('a');
await testSchema.save();
});
it('addField permission not required for adding a nested property', async () => {
const obj = new Parse.Object('test_7371');
obj.set('a', {});
await obj.save();
obj.set('a.b', 2);
await obj.save();
});
it('addField permission not required for modifying a nested property', async () => {
const obj = new Parse.Object('test_7371');
obj.set('a', { b: 1 });
await obj.save();
obj.set('a.b', 2);
await obj.save();
});
});
it('should aceept class-level permission with userid of any length', async done => { it('should aceept class-level permission with userid of any length', async done => {
await global.reconfigureServer({ await global.reconfigureServer({
customIdSize: 11, customIdSize: 11,

View File

@@ -894,7 +894,7 @@ class DatabaseController {
if (object[field] && object[field].__op && object[field].__op === 'Delete') { if (object[field] && object[field].__op && object[field].__op === 'Delete') {
return false; return false;
} }
return schemaFields.indexOf(field) < 0; return schemaFields.indexOf(getRootFieldName(field)) < 0;
}); });
if (newKeys.length > 0) { if (newKeys.length > 0) {
// adds a marker that new field is being adding during update // adds a marker that new field is being adding during update