From 5861996cb0091cc07076a20235b2d2f1f0e34bea Mon Sep 17 00:00:00 2001 From: Arthur Cinader Date: Thu, 9 Feb 2017 15:20:10 -0800 Subject: [PATCH] explicitly check if auth keys are undefined Simply checking if they are truthy causes a false negative if the value is ''. --- src/middlewares.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/middlewares.js b/src/middlewares.js index 2edbb3b1..209f3d3f 100644 --- a/src/middlewares.js +++ b/src/middlewares.js @@ -122,10 +122,10 @@ export function handleParseHeaders(req, res, next) { // to preserve original behavior. const keys = ["clientKey", "javascriptKey", "dotNetKey", "restAPIKey"]; const oneKeyConfigured = keys.some(function(key) { - return req.config[key]; + return req.config[key] !== undefined; }); const oneKeyMatches = keys.some(function(key){ - return req.config[key] && info[key] == req.config[key]; + return req.config[key] !== undefined && info[key] === req.config[key]; }); if (oneKeyConfigured && !oneKeyMatches) {