Fix flaky tests (#3724)

* adds continuation to silence rejected promises

* Wrap json parsing

spec/AuthenticationAdapters.spec.js

@@ -10,8 +10,12 @@ describe('AuthenticationProviers', function() {
       var provider = require("../src/Adapters/Auth/" + providerName);
       jequal(typeof provider.validateAuthData, "function");
       jequal(typeof provider.validateAppId, "function");
-      jequal(provider.validateAuthData({}, {}).constructor, Promise.prototype.constructor);
+      const authDataPromise = provider.validateAuthData({}, {});
-      jequal(provider.validateAppId("app", "key", {}).constructor, Promise.prototype.constructor);
+      const validateAppIdPromise = provider.validateAppId("app", "key", {});
+      jequal(authDataPromise.constructor, Promise.prototype.constructor);
+      jequal(validateAppIdPromise.constructor, Promise.prototype.constructor);
+      authDataPromise.then(()=>{}, ()=>{});
+      validateAppIdPromise.then(()=>{}, ()=>{});
       done();
     });
   });

src/Adapters/Auth/facebook.js

@@ -43,7 +43,11 @@ function graphRequest(path) {
         data += chunk;
       });
       res.on('end', function() {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function() {

src/Adapters/Auth/github.js

@@ -36,7 +36,11 @@ function request(path, access_token) {
         data += chunk;
       });
       res.on('end', function() {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function() {

src/Adapters/Auth/google.js

@@ -55,7 +55,11 @@ function request(path) {
         data += chunk;
       });
       res.on('end', function() {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function() {

src/Adapters/Auth/janrainengage.js

@@ -41,7 +41,7 @@ function request(api_key, auth_token) {
     }
   };
 
-  return new Promise(function (resolve) {
+  return new Promise(function (resolve, reject) {
     // Create the post request.
     var post_req = https.request(post_options, function (res) {
       var data = '';
@@ -52,7 +52,12 @@ function request(api_key, auth_token) {
       });
       // Once we have all the data, we can parse it and return the data we want.
       res.on('end', function () {
-        resolve(JSON.parse(data));
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
+        resolve(data);
       });
     });
 

src/Adapters/Auth/linkedin.js

@@ -42,7 +42,11 @@ function request(path, access_token, is_mobile_sdk) {
         data += chunk;
       });
       res.on('end', function() {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function() {

src/Adapters/Auth/meetup.js

@@ -35,7 +35,11 @@ function request(path, access_token) {
         data += chunk;
       });
       res.on('end', function() {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function() {

src/Adapters/Auth/qq.js

@@ -32,7 +32,11 @@ function graphRequest(path) {
           throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'qq auth is invalid for this user.');
         }
         data = data.substring(starPos + 1,endPos - 1);
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function () {

src/Adapters/Auth/spotify.js

@@ -49,7 +49,11 @@ function request(path, access_token) {
         data += chunk;
       });
       res.on('end', function() {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function() {

src/Adapters/Auth/vkontakte.js

@@ -47,7 +47,11 @@ function request(host, path) {
         data += chunk;
       });
       res.on('end', function () {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function () {

src/Adapters/Auth/wechat.js

@@ -26,7 +26,11 @@ function graphRequest(path) {
         data += chunk;
       });
       res.on('end', function () {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
     }).on('error', function () {

src/Adapters/Auth/weibo.js

@@ -39,7 +39,11 @@ function graphRequest(access_token) {
         data += chunk;
       });
       res.on('end', function () {
-        data = JSON.parse(data);
+        try {
+          data = JSON.parse(data);
+        } catch(e) {
+          return reject(e);
+        }
         resolve(data);
       });
       res.on('error', function () {