joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix intense CPU usage when sessionToken is invalid in liveQuery (#5126)

Browse Source 
* Ensure we bail out early when auth or userId are not provided (sessionToken fetch is invalid)

* Adds changelog

* better handling of session token errors and client tokens
This commit is contained in:
Florent Vilmart
2018-10-18 07:21:31 -04:00
committed by GitHub
parent 318a784e20
commit 4b7037ac9a
3 changed files with 74 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
spec/ParseLiveQueryServer.spec.js
View File

@@ -98,6 +98,14 @@ describe('ParseLiveQueryServer', function() {
if (sessionToken === 'pleaseThrow') {
return Promise.reject();
}
if (sessionToken === 'invalid') {
return Promise.reject(
new Parse.Error(
Parse.Error.INVALID_SESSION_TOKEN,
'invalid session token'
)
);
}
return Promise.resolve(
new auth.Auth({ cacheController, user: { id: testUserId } })
);
@@ -1629,6 +1637,17 @@ describe('ParseLiveQueryServer', function() {
expect(parseLiveQueryServer.authCache.get('pleaseThrow')).toBe(undefined);
});
it('should keep a cache of invalid sessions', async () => {
const parseLiveQueryServer = new ParseLiveQueryServer({});
const promise = parseLiveQueryServer.getAuthForSessionToken('invalid');
expect(parseLiveQueryServer.authCache.get('invalid')).toBe(promise);
// after the promise finishes, it should have removed it from the cache
await promise;
const finalResult = await parseLiveQueryServer.authCache.get('invalid');
expect(finalResult.error).not.toBeUndefined();
expect(parseLiveQueryServer.authCache.get('invalid')).not.toBe(undefined);
});
afterEach(function() {
jasmine.restoreLibrary(
'../lib/LiveQuery/ParseWebSocketServer',