Fixes issue where info logs would appear in error logs (#2647)

* Reproduction of #2639

* Make sure the error level options is enforced
This commit is contained in:
Florent Vilmart
2016-09-04 12:07:40 -04:00
committed by GitHub
parent 5676a6fbda
commit 33e3993a37
2 changed files with 13 additions and 6 deletions

View File

@@ -16,11 +16,19 @@ describe('info logs', () => {
}, (results) => { }, (results) => {
if (results.length == 0) { if (results.length == 0) {
fail('The adapter should return non-empty results'); fail('The adapter should return non-empty results');
done();
} else { } else {
expect(results[0].message).toEqual('testing info logs'); expect(results[0].message).toEqual('testing info logs');
done();
} }
// Check the error log
// Regression #2639
winstonLoggerAdapter.query({
from: new Date(Date.now() - 500),
size: 100,
level: 'error'
}, (results) => {
expect(results.length).toEqual(0);
done();
});
}); });
}); });
}); });

View File

@@ -18,16 +18,15 @@ function updateTransports(options) {
delete transports['parse-server-error']; delete transports['parse-server-error'];
} else if (!_.isUndefined(options.dirname)) { } else if (!_.isUndefined(options.dirname)) {
transports['parse-server'] = new (DailyRotateFile)( transports['parse-server'] = new (DailyRotateFile)(
Object.assign({ Object.assign({}, {
filename: 'parse-server.info', filename: 'parse-server.info',
name: 'parse-server', name: 'parse-server',
}, options)); }, options));
transports['parse-server-error'] = new (DailyRotateFile)( transports['parse-server-error'] = new (DailyRotateFile)(
Object.assign({ Object.assign({}, {
filename: 'parse-server.err', filename: 'parse-server.err',
name: 'parse-server-error', name: 'parse-server-error',
level: 'error' }, options, { level: 'error'}));
}, options));
} }
transports.console = new (winston.transports.Console)( transports.console = new (winston.transports.Console)(