Auth module refactoring in order to be reusable (#4940)

* Auth module refactoring in order to be reusable

* Ensure cache controller is properly forwarded from helpers

* Nits
This commit is contained in:
Florent Vilmart
2018-08-09 13:02:06 -04:00
committed by GitHub
parent 5d91c1057f
commit 2ae603574c
4 changed files with 169 additions and 94 deletions

View File

@@ -142,7 +142,7 @@ describe('Parse Role testing', () => {
});
it("should recursively load roles", (done) => {
function testLoadRoles(config, done) {
const rolesNames = ["FooRole", "BarRole", "BazRole"];
const roleIds = {};
createTestUser().then((user) => {
@@ -159,7 +159,7 @@ describe('Parse Role testing', () => {
return createRole(rolesNames[2], anotherRole, null);
}).then((lastRole) => {
roleIds[lastRole.get("name")] = lastRole.id;
const auth = new Auth({ config: Config.get("test"), isMaster: true, user: user });
const auth = new Auth({ config, isMaster: true, user: user });
return auth._loadRoles();
})
}).then((roles) => {
@@ -172,6 +172,14 @@ describe('Parse Role testing', () => {
fail("should succeed")
done();
});
}
it("should recursively load roles", (done) => {
testLoadRoles(Config.get('test'), done);
});
it("should recursively load roles without config", (done) => {
testLoadRoles(undefined, done);
});
it("_Role object should not save without name.", (done) => {