Removes GCS Adapter from provided adapters

* 💣 removes exposed GCS files adapter

- Should fix problems with GCS
- Throws error that shows the right repo
This commit is contained in:
Florent Vilmart
2016-04-05 18:18:49 -04:00
parent 0b2dc12143
commit 1eb2a87f9f
4 changed files with 15 additions and 8 deletions

View File

@@ -34,9 +34,8 @@
"multer": "^1.1.0", "multer": "^1.1.0",
"parse": "^1.8.0", "parse": "^1.8.0",
"parse-server-fs-adapter": "^1.0.0", "parse-server-fs-adapter": "^1.0.0",
"parse-server-gcs-adapter": "^1.0.0",
"parse-server-push-adapter": "^1.0.0", "parse-server-push-adapter": "^1.0.0",
"parse-server-s3-adapter": "^1.0.0", "parse-server-s3-adapter": "^1.0.1",
"parse-server-simple-mailgun-adapter": "^1.0.0", "parse-server-simple-mailgun-adapter": "^1.0.0",
"redis": "^2.5.0-1", "redis": "^2.5.0-1",
"request": "^2.65.0", "request": "^2.65.0",
@@ -61,7 +60,8 @@
"gaze": "^0.5.2", "gaze": "^0.5.2",
"jasmine": "^2.3.2", "jasmine": "^2.3.2",
"mongodb-runner": "3.1.15", "mongodb-runner": "3.1.15",
"nodemon": "^1.8.1" "nodemon": "^1.8.1",
"parse-server-gcs-adapter": "^1.0.0"
}, },
"scripts": { "scripts": {
"dev": "npm run build && node bin/dev", "dev": "npm run build && node bin/dev",

View File

@@ -261,9 +261,9 @@ describe('server', () => {
done(); done();
}); });
it('exposes all the "core" adapters', done => { it('core adapters are not exposed anymore', done => {
expect(ParseServer.S3Adapter).toThrow(); expect(ParseServer.S3Adapter).toThrow();
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter requires an projectId'); expect(ParseServer.GCSAdapter).toThrow('GCSAdapter is not provided by parse-server anymore; please install parse-server-gcs-adapter');
expect(ParseServer.FileSystemAdapter).toThrow(); expect(ParseServer.FileSystemAdapter).toThrow();
done(); done();
}); });

5
src/deprecated.js Normal file
View File

@@ -0,0 +1,5 @@
export function useExternal(name, moduleName) {
return function() {
throw `${name} is not provided by parse-server anymore; please install ${moduleName}`;
}
}

View File

@@ -1,8 +1,8 @@
import winston from 'winston'; import winston from 'winston';
import ParseServer from './ParseServer'; import ParseServer from './ParseServer';
import GCSAdapter from 'parse-server-gcs-adapter'; import S3Adapter from 'parse-server-s3-adapter'
import S3Adapter from 'parse-server-s3-adapter'; import FileSystemAdapter from 'parse-server-fs-adapter'
import FileSystemAdapter from 'parse-server-fs-adapter'; import { useExternal } from './deprecated'
if (process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER) { if (process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER) {
winston.level = 'silly'; winston.level = 'silly';
@@ -20,5 +20,7 @@ let _ParseServer = function(options) {
// Mount the create liveQueryServer // Mount the create liveQueryServer
_ParseServer.createLiveQueryServer = ParseServer.createLiveQueryServer; _ParseServer.createLiveQueryServer = ParseServer.createLiveQueryServer;
let GCSAdapter = useExternal('GCSAdapter', 'parse-server-gcs-adapter');
export default ParseServer; export default ParseServer;
export { S3Adapter, GCSAdapter, FileSystemAdapter, _ParseServer as ParseServer }; export { S3Adapter, GCSAdapter, FileSystemAdapter, _ParseServer as ParseServer };