[WIP] Enable test suite to be randomized (#7265)

* initial run

* Update ParseGraphQLServer.spec.js

* temporarily enable reporter

* Bump retry limit

* fix undefined database

* try to catch error

* Handle LiveQueryServers

* Update Config.js

* fast-fail false

* Remove usage of AppCache

* oops

* Update contributing guide

* enable debugger, try network retry attempt 1

* Fix ldap unbinding

* move non specs to support

* add missing mock adapter

* fix Parse.Push

* RestController should match batch.spec.js

* Remove request attempt limit

* handle index.spec.js

* Update CHANGELOG.md

* Handle error: tuple concurrently updated

* test transactions

* Clear RedisCache after every test

* LoggerController.spec.js

* Update schemas.spec.js

* finally fix transactions

* fix geopoint deadlock

* transaction with clean database

* batch.spec.js

src/Adapters/Auth/ldap.js

@@ -95,6 +95,8 @@ function searchForGroup(client, options, id, resolve, reject) {
       }
     });
     res.on('error', () => {
+      client.unbind();
+      client.destroy();
       return reject(new Parse.Error(Parse.Error.INTERNAL_SERVER_ERROR, 'LDAP group search failed'));
     });
   });

src/Adapters/Cache/RedisCacheAdapter/index.js

@@ -5,8 +5,9 @@ import { KeyPromiseQueue } from './KeyPromiseQueue';
 const DEFAULT_REDIS_TTL = 30 * 1000; // 30 seconds in milliseconds
 const FLUSH_DB_KEY = '__flush_db__';
 
-function debug() {
-  logger.debug.apply(logger, ['RedisCacheAdapter', ...arguments]);
+function debug(...args: any) {
+  const message = ['RedisCacheAdapter: ' + arguments[0]].concat(args.slice(1, args.length));
+  logger.debug.apply(logger, message);
 }
 
 const isValidTTL = ttl => typeof ttl === 'number' && ttl > 0;
@@ -33,13 +34,13 @@ export class RedisCacheAdapter {
   }
 
   get(key) {
-    debug('get', key);
+    debug('get', { key });
     return this.queue.enqueue(
       key,
       () =>
         new Promise(resolve => {
           this.client.get(key, function (err, res) {
-            debug('-> get', key, res);
+            debug('-> get', { key, res });
             if (!res) {
               return resolve(null);
             }
@@ -51,7 +52,7 @@ export class RedisCacheAdapter {
 
   put(key, value, ttl = this.ttl) {
     value = JSON.stringify(value);
-    debug('put', key, value, ttl);
+    debug('put', { key, value, ttl });
 
     if (ttl === 0) {
       // ttl of zero is a logical no-op, but redis cannot set expire time of zero
@@ -86,7 +87,7 @@ export class RedisCacheAdapter {
   }
 
   del(key) {
-    debug('del', key);
+    debug('del', { key });
     return this.queue.enqueue(
       key,
       () =>

src/Controllers/SchemaController.js

@@ -1215,16 +1215,10 @@ export default class SchemaController {
     const promises = [];
 
     for (const fieldName in object) {
-      if (object[fieldName] === undefined) {
-        continue;
-      }
-      const expected = getType(object[fieldName]);
-      if (expected === 'GeoPoint') {
+      if (object[fieldName] && getType(object[fieldName]) === 'GeoPoint') {
         geocount++;
       }
       if (geocount > 1) {
-        // Make sure all field validation operations run before we return.
-        // If not - we are continuing to run logic, but already provided response from the server.
         return Promise.reject(
           new Parse.Error(
             Parse.Error.INCORRECT_TYPE,
@@ -1232,6 +1226,12 @@ export default class SchemaController {
           )
         );
       }
+    }
+    for (const fieldName in object) {
+      if (object[fieldName] === undefined) {
+        continue;
+      }
+      const expected = getType(object[fieldName]);
       if (!expected) {
         continue;
       }